The bug
Despite that MC-127326 has been fixed, the particles of rain on the water appear below the upper layer of water in the oceans.
How to reproduce
Video demonstrating the issue: https://youtu.be/eKOr2Dj-iEE
Code analysis
Code analysis by @unknown can be found in this comment.
Linked issues
is duplicated by 28
MC-131887
Rain splash particles appear underwater
Resolved
MC-131892
Rain particles one block underneath water
Resolved
MC-132098
When Player's Head is at the top of a body of water while there is a thunderstorm or rainstorm precipitation appears to be landing at the top of the second block of water
Resolved
MC-132126
Rain drops apear one block below water surface
Resolved
MC-133197
Raining particles are displayed 1 block below the water surface
Resolved
23 more links
Attachments
Comments 14
Was about to make a ticket about this. Good thing I searched. Here is a video showing the problem better than screenshots can show. https://youtu.be/eKOr2Dj-iEE
From what I can see the Bug is in the ParticleRain class where it detects the fluid level incorrectly.
if (ifluidstate.getHeight() > 0.0F) {
d0 = (double)ifluidstate.getHeight();
} else {d0 should be calculating the fluid height from top down, as in previous versions of the game. (1.0 - height).
if (ifluidstate.getHeight() > 0.0F) {
d0 = 1.0D - (double)ifluidstate.getHeight();
} else {
4 more comments
Confirmed, "rain hitting block" particles appear 1 block below water.