The bug
Despite that MC-127326 has been fixed, the particles of rain on the water appear below the upper layer of water in the oceans.
How to reproduce
Video demonstrating the issue: https://youtu.be/eKOr2Dj-iEE
Code analysis
Code analysis by @unknown can be found in this comment.
Related issues
is duplicated by
MC-131887
Rain splash particles appear underwater
MC-131892
Rain particles one block underneath water
MC-132098
When Player's Head is at the top of a body of water while there is a thunderstorm or rainstorm precipitation appears to be landing at the top of the second block of water
MC-132126
Rain drops apear one block below water surface
MC-133197
Raining particles are displayed 1 block below the water surface
MC-133527
Rain particles appearing one block below the water
MC-133624
rain particle ins't right
MC-133632
The rainfall get error on the water
MC-134064
Rain splash particles/smoke particles don't appear on surface of water/lava
MC-134106
You can see the Rain if you're underwater
MC-135020
Rain particles render one block under the water
MC-135238
Rain splash particles under water
MC-135835
Raindrop splash in water
MC-135888
Rain particles appear one block below water
MC-136168
rain under water
MC-137138
Water drops from rain splash one block under water
MC-137440
null
MC-139260
Raindrop 'splash' particle is one block under surface of water
MC-148554
Rain particles are 1 block below the water level
MC-148592
Minecraft raindrops animation is 1 block below water (there are rain splashes 1 block under water)
MC-151256
Rain particles are rendered at the bottom of the surface water
MC-167126
Rain particles on water goes underwater
MC-167202
Rain particles render one block in the water?
MC-167548
Rain particles under the water block
MC-167696
Rain from one block in underwater
MC-167750
Water rendered over rain & rain particles in water
MC-168823
Rain Particle Bug
MC-175864
Rain particles appears one block below the water
Attachments
Comments
migrated
migrated
Confirmed, "rain hitting block" particles appear 1 block below water.
migrated
Affects 1.13-pre2.
Asteraoth
Confirmed for 1.13.1
migrated
Was about to make a ticket about this. Good thing I searched. Here is a video showing the problem better than screenshots can show. https://youtu.be/eKOr2Dj-iEE
From what I can see the Bug is in the ParticleRain class where it detects the fluid level incorrectly.
if (ifluidstate.getHeight() > 0.0F) {
d0 = (double)ifluidstate.getHeight();
} else {d0 should be calculating the fluid height from top down, as in previous versions of the game. (1.0 - height).
if (ifluidstate.getHeight() > 0.0F) {
d0 = 1.0D - (double)ifluidstate.getHeight();
} else {
Makzevu
Confirmed for 1.13.2-pre1.
migrated
Seems to be in the newest 1.14 snapshots as well. 18w44a has it.
migrated
Confirmed for 19w07a.
migrated
I have the same problem in 1.14 pre-release 2
migrated
Just wanted to touch base with this. Confirmed for 1.14 official release.
A new video showing more detail of the particle vs fluid height bug: https://youtu.be/eoMUmB0zqvg
Same as my last comment, the bug can be fixed by calculating the 1 minus fluid height instead of 0 plus fluid height.
fluidstate.getHeight() returns the amount of air above the fluid's surface, NOT the amount of fluid under the surface.
This can clearly be seen in this video where each fluid height step up makes the particles spawn height step down.
migrated
Confirmed for 1.14.2 pre-release 1
migrated
This bug can also be reproduced in lava
[media]
migrated
Affects 1.15 Pre-release 7
migrated
Affects 1.15.
migrated
Pretty sure water renders over rain.
Felix Jones