[MC-147659] Some witch huts spawn the incorrect cat

The bug

Cats in witch huts are only supposed to be black, but they occasionally don't spawn as the correct type.

How to reproduce

Seed: -2326619757953434803
Coordinates: /teleport @s -1244 71 818

Seed: -953538683905638291
Coordinates: /teleport @s 89.17 72.00 114.39

Attachments

Screen Shot 2019-04-07 at 2.18.08 PM.png

Screen Shot 2019-04-07 at 2.18.27 PM.png

Comments

gaspoweredpick 2019-04-07T21:35:28Z

When using the seed -953538683905638291 and going to the village witch hut near spawn, the resulting cat will also be incorrect (and the village will overlap the hut currently, which is a different "problem").

-(Note: don't use the seed ~~953538683905638291 if you want to beat the game, unless MC-88301 is fixed)~~

MukiTanuki 2019-11-15T09:27:30Z

affects 19w46b

migrated 2019-11-15T09:29:21Z

You can just update the affected versions without commenting, the comment will add nothing to the ticket.

MukiTanuki 2019-12-10T22:05:26Z

Affects 1.15

Orbic 2020-03-14T01:36:11Z

Affects 20w11a

Orbic 2020-03-18T21:44:31Z

In 20w12a

Orbic 2020-06-10T18:07:46Z

In 1.16 Pre 3

migrated 2020-06-28T06:21:47Z

This happens because the cat type is prepared before it's location is set.

To fix, just set the position before preparing the type.

https://github.com/pl3xgaming/Purpur/blob/ed7b2022b7f68dcd35a6654bd617596fc4883eef/patches/server/0020-Fix-non-black-cat-types-spawning-in-swamp-huts.patch

Avoma 2021-02-10T16:14:56Z

Can confirm in 21w05b.

migrated 2021-08-28T03:27:25Z

I am unable to reproduce this issue in 1.17.1.