[MC-154422] /loot give causes the item to be deleted if player inventory is full

The bug

Doing a /loot give @s ... for a player in Survival or Adventure mode while the player inventory is full causes the items to be deleted, rather than spawned as item entities, contrary to the behavior exhibited by the /give command when the player inventory is full.

Reproduction steps

Fill your complete inventory
```
/give @s minecraft:wooden_sword 36
```
Switch to Survival mode
Use /loot give
```
/loot give @s loot minecraft:blocks/acacia_button
```
❌ The command feedback says "Dropped 0 items" and you did not get any item, neither was the item entity dropped

Attachments

MC-154422.mp4

Comments 11

MukiTanuki 2019-11-22T00:25:44Z

affects 1.15 pre-release 1

Kovi 2020-05-09T00:56:36Z

confirmed in 20w19a.

This is a pretty serious issue since it makes the command work incorrectly. Most users of the command probably assume that loot will drop if a player's inventory is full.

marcono1234 2020-12-21T22:28:31Z

@@unknown, this report is about /loot give, not the /give command. /give deleting items for Creative mode is likely MC-8409 or closely related and probably intended.