mojira.dev
MC-177457

Fire charge and flint and steel sound event names do not follow item IDs

The IDs contain "firecharge" and "flintandsteel", which should be changed to "fire_charge" and "flint_and_steel" to fit the item IDs.

Linked issues

Attachments

Comments 13

Can confirm in 20w51a.

Can confirm in 21w05b.

Can confirm in 21w06a.

Can confirm in 1.16.5 and 21w08b.

Can confirm in 21w15a.

3 more comments

I can confirm this behavior in 1.18 Release Candidate 3.

Here's a code analysis along with a potential fix regarding this issue. The following is based on a decompiled version of Minecraft 1.17.1 using MCP-Reborn.

Code Analysis:

net.minecraft.sounds.SoundEvents.java

public class SoundEvents {
   ...
   public static final SoundEvent FIRECHARGE_USE = register("item.firecharge.use");
   ...
   public static final SoundEvent FLINTANDSTEEL_USE = register("item.flintandsteel.use");
   ...

If we look at the above class, we can see that the "firecharge use" and "flintandsteel use" sound events both use the incorrect item IDs for fire charges and flint and steels. The incorrect and current item IDs for both of these sound events are "firecharge" and "flintandsteel" and the correct and expected item IDs would instead be "fire_charge" and "flint_and_steel".

Potential Fix:

Simply renaming these two sound events accordingly to match their item IDs should resolve this issue. The correct line of code within its class should look something like the following:

net.minecraft.sounds.SoundEvents.java

public class SoundEvents {
   ...
   public static final SoundEvent FIRE_CHARGE_USE = register("item.fire_charge.use");
   ...
   public static final SoundEvent FLINT_AND_STEEL_USE = register("item.flint_and_steel.use");
   ...

Can confirm in 1.18.1.

Can confirm in 1.18.2.

Can confirm in 1.19.

Can confirm in 1.19.2.

muzikbike

(Unassigned)

Confirmed

Platform

Low

Resource Packs

incorrect-sound-event-id, sound-testing-zone

20w14a, 20w15a, 20w18a, 20w20a, 20w21a, ..., 1.19, 1.19.2, 1.20.1, 1.20.2, 1.21

Retrieved