[MC-260148] show_notification only works for shaped crafting recipes

The show_notification is supposed to determines if a notification is shown for recipes, but it is only supported for the crafting_shaped recipe serializer. For all other recipes it always shows the notification.

Code Analysis

The Recipe class has a default implementation for showNotification, returning true. Only ShapedRecipe actually overwrites this method and implements parsing show_notification from json.

Comments 6

Tis_awesomeness 2023-02-23T21:14:12Z

Can confirm in 1.19.4-pre1. To reproduce:

Create a new world with the attached datapack installed. The datapack adds "show_notification": false to the clay ball --> brick smelting recipe and the clay ball --> clay crafting recipe.
Put a clay ball in your inventory.
Notice that the brick smelting recipe shows as a notification, but the clay block crafting recipe does not. Neither recipe should show.

Conure512 2024-02-29T01:30:53Z

Can confirm in 24w09a

ClassyElm123 2024-04-25T03:43:25Z

I can confirm this issue is still present in 1.20.5

K7Y 2024-04-25T06:30:54Z

Yep issue is also still present for me in 1.20.5

976Altair 2025-01-27T04:26:31Z

Wait, how does show_notitication in the recipe files affect / compare to show_toast in the advancement recipe files?

Dhranios 2025-01-27T05:46:17Z

Advancement recipe files are just normal advancements without a display. There's no advancement types.