[MC-271729] Armadillo scute drops are not affected by the mob_drops game rule

Summary:
Relates to MC-136208, which was surprisingly fixed. Armadillos continue to drop scutes even when the gamerule doMobLoot is disabled, a behavior inconsistent with turtles due to the fix. This inconsistency might be intentional.

Steps to reproduce:

```
/gamerule doMobLoot false
```

/summon minecraft:armadillo ~ ~ ~ {scute_time:0}

Observed result:
The armadillo dropped an armadillo scute.

Expected result:
The armadillo should not drop an armadillo scute.

Note:
This gamerule likely shouldn't influence scute drops when using a brush on the armadillo.

Video:

[media]

Code analysis by @unknown

Linked issues

relates to 1

MC-136208 Scute is not affected by doMobLoot Resolved

Attachments

Comments 2

Viradex 2024-06-30T08:45:20Z

Can confirm in 1.21.

Code Analysis / Possible Fix

Minecraft 1.21 using Yarn mappings. This code is located in ArmadilloEntity#mobTick, and defines the conditions for an armadillo scute to drop:

if (this.isAlive() && !this.isBaby() && --this.nextScuteShedCooldown <= 0) {
    this.playSound(SoundEvents.ENTITY_ARMADILLO_SCUTE_DROP, 1.0F, (this.random.nextFloat() - this.random.nextFloat()) * 0.2F + 1.0F);
    this.dropItem(Items.ARMADILLO_SCUTE);
    this.emitGameEvent(GameEvent.ENTITY_PLACE);
    this.nextScuteShedCooldown = this.getNextScuteShedCooldown();
}

There is no check to see if the gamerule doMobLoot is true. Adding a check to see if it is true should fix this issue, as shown below:

if (this.isAlive() && !this.isBaby() && --this.nextScuteShedCooldown <= 0 && this.getWorld().getGameRules().getBoolean(GameRules.DO_MOB_LOOT)) {
    // Same code as above
}

muzikbike 2024-09-16T16:30:49Z

Is this still the case with the 24w37a changes?