Enchant the item with a sharpness enchantment.
Critical attack with it.
Observed result
The damage of a critical hit is the item's original attack damage x 1.5 + increased damage due to sharpness.
Expected result
The damage of a critical hit is (the item's original attack damage + increased damage due to sharpness) x 1.5.
Linked issues
is duplicated by 2
Attachments
Comments 6
Can confirm for 1.21 Pre-Release 3.
Note that it happens for all enchantments, not only sharpness.
And I don't think MC-271888 is a duplicate of this issue, maybe related but I'm not even sure of that.
Works as Intended / Feature Request, this is how it is intentionally designed for the current combat system to reduce damage enchantment effectiveness. The calculations were intentionally changed in the Combat Tests to the ones you suggested as a balancing change, it was not "fixed", this is not a bug.
But this has side effects with the enchantments that reduce the damage instead of increasing. It would be better to have a effect to control crit damage as well if this is intentional.
Can confirm.