What I expected to happen was:
Firework light flash texture being bright - because it's a LIGHT flash. Same goes for the colored firework particles.
What really happend was:
The light flash is actually dark (during nighttime practically not visible, during daytime it looks really odd). The colored particles should also appear bright (less visible during daytime, "glowing" bright appearance during nighttime).
Reproduction command provided by @unknown here
Related issues
is duplicated by
Attachments
Comments
migrated
_zombiehunter
woops, really forgot about this. Yep, firework light flash didn't change in 1.5 and 13w11a, still looking weird. Best would be if Mojang changes the firework particle rendering (including the light flash particle texture!) completely to give them a brigher appeareance, similar as used in MCPatchers Custom Colors mod (giving them a more "glowing" appearance, as if they would give off light >>> by far more realistic !).
_zombiehunter
Updated the tickets title, description and added new screenshots to compare current and expected behavior.
migrated
Can you take more "expected" images during night? Are you proposing that at night the colors aren't washed out? Because the daytime image looks ugly.
It would be cool if the particles were blended in a way that you could see them better on a dark background, or better yet, actually had a "luminosity" factor that made them display differently in high and low light level environments. Not just day/night, but if you used one in a cave, it would create a flash of light (just a rendering thing though).
_zombiehunter
@insomniac_lemon:
The pale colors at night-time are simply hard-coded color values (they can be easily changed using MCPatchers Custom Colors mod to show more intense colors). Mojang could change the values too, I don't know why they prefer fireworks having such pale colors. This issue ticket refers mainly to the ugly appearance of firework particles during daytime (a light flash being dark => wrong rendering method), making the particles more colorful to better blend with dark backgrounds isn't directly related to this, so I drop the night-time images here:
Current appearance (pale particles):
http://i.imgur.com/QpJzSdv.jpg
Expected appearance (changed color value to RGB #FF0000):
http://i.imgur.com/nl6IvfR.jpg
To fix the ugly and dark appearance during daytime, the firework particles and light flash color values should simply be added to the sky color value:
black=000000, red: FF0000 --> 000000+FF0000=FF0000 --> normal red during nighttime, but particles much brighter during daytime because the sky is light blue --> much more realistic appearance! MCPatcher is doing it that way, it works fine and looks great.
migrated
Is this still a concern in the current Minecraft version 14w21b / Launcher version 1.4.4 or later? If so, please update the affected versions in order to best aid Mojang ensuring bugs are still valid in the latest releases/pre-releases.
migrated
you mean 27b
_zombiehunter
Awaiting response ... hmm ... let's see ...
Nope - firework rendering hasn't changed up to 1.8.1-pre1, still getting a dark light flash
galaxy_2alex
Is this still a concern in the current Minecraft version? If so, please update the affected versions in order to best aid Mojang ensuring bugs are still valid in the latest releases/pre-releases. If this has been done, we can reopen the issue.
Keep in mind that the "Resolved"-Status on this ticket just means "Answered", and that we are waiting for further information on whether this issue still exists or not. It will be reopened as soon as the requested information has been delivered.
_zombiehunter
Yes, still a problem in recent MC versions up to 16w38a ...
migrated
Weird, I cannot reproduce this issue for 1.13.1.
_zombiehunter
Kraif, that might be because the light flash isn't rendered at all right now, see MC-131356.
_zombiehunter
Fixing this should theoretically be much easier now that particles.png has been split into separate files.
migrated
Please do not mark unreleased versions as affected.
You don't have access to them yet.
Avoma
Can confirm in 20w48a.
Avoma
Can confirm in 20w49a.
Avoma
Can confirm in 20w51a.
Avoma
Can confirm in 21w03a.
Avoma
Can confirm in 21w05b.
Avoma
Can confirm in 21w06a.
Avoma
Can confirm in 21w07a. Video attached.
Avoma
Can confirm in 1.16.5 and 21w11a.
Avoma
Can confirm in 21w15a. You can use the following command to reproduce this issue:
/give @s firework_rocket{Fireworks:{Flight:1,Explosions:[{Type:1,Flicker:1,Trail:1,Colors:[I;12801229],FadeColors:[I;11743532]}]}}Can confirm in 21w17a.
Avoma
Can confirm in 1.17.1.
Avoma
Can confirm in 1.18.1.
Avoma
Can confirm in 1.18.2.
Avoma
Can confirm in 1.19.
Avoma
Can confirm in 1.19.2.
Watermelon_Sir
This still occurs in 1.21.4. They're affected by lighting, if you put fireworks down two tubes of tinted glass, you'll see that one in a tube that is lit on the inside displays brighter that an unlit tube, even on the outside of the tube where the lighting is the same. This is odd for a light flash, that you'd not expect to act like fog.