mojira.dev
MC-46710

4 blocks wide paintings need 5 blocks space / Paintings popping off wall when blocks around it are broken

4x4 paintings need 4x5 space to be there i cant show a good picture but im sure you get it

Linked issues

MC-52161 3x4 Painting needs a 4x5 space and 4x4 painting needs a 5x5 space Resolved MC-53942 Paintings bigger than 2x2 popping off wall when blocks around it are broken. Resolved MC-55232 "Fighters" Painting detecting wrong blocks (pops off) Resolved MC-61685 Large Painting bug Resolved MC-66360 4x3 painting falls off the wall Resolved

Attachments

Comments 20

Steps to reproduce:

  • Place a 4x4 painting on a bigger wall

  • Destroy some blocks on the right of the painting

  • Painting will fall off the wall

According to MC-55232 the painting center is offset one block to the left

Confirmed for 14w33a

10 more comments

My mc world is filled with my own customized kx.png paintings. When I upgraded from 1.7.9 to 1.8.1 those 4x4 paintings dropped off in all areas where there was only a 4x4 space. Disappointing that 1.8.1 is not "better" than an earlier version or that a model wall filled with the kz.png paintings was not tested before a new release.

Note: I use optifine.

I want to comment that 1) even if the walls are large, a 4x4 painting does did not work if there are paintings surrounding the 4x4 empty space. 2) the 4x4 paintings do NOT work on a large wall filled with paintings even if there is an open 4 high x 5 wide open space. 3) if there is a stand alone 4x4 block wall a 4x4 painting will stick, but only if the painting hangs off the left side over empty space.

This forum is just over one year old with no solution found yet. I'm glad the topic is still open. I will either have to go back to 1.7.9 or go back and rework all of my structures to make this work.

Question: Is there a mod that will fix this problem?
Unrelated question: Are there mods, like "More Paintings mod" that work with 1.8.1 and optifine?

@James Taylor Flores:
This should fix the problem (if someone want to make a mod with it, feel free) (patch for mcp 1.8.0 code)

diff --git a/minecraft/net/minecraft/entity/EntityHanging.java b/minecraft/net/minecraft/entity/EntityHanging.java
--- a/minecraft/net/minecraft/entity/EntityHanging.java
+++ b/minecraft/net/minecraft/entity/EntityHanging.java
@@ -118,12 +118,14 @@ public abstract class EntityHanging exte
             BlockPos var3 = this.hangingPosition.offset(this.field_174860_b.getOpposite());
             EnumFacing var4 = this.field_174860_b.rotateYCCW();
 
-            for (int var5 = 0; var5 < var1; ++var5)
+            for (int var5 = 0; var5 < var1; var5++)
             {
                 for (int var6 = 0; var6 < var2; ++var6)
                 {
-                    BlockPos var7 = var3.offset(var4, var5).up(var6);
-                    Block var8 = this.worldObj.getBlockState(var7).getBlock();
+                    int offsetX = var5 - ((this.getWidthPixels() - 1) / 32);
+                    int offsetY = var6 - ((this.getHeightPixels() - 1) / 32);
+                    BlockPos blockPos = var3.offset(var4, offsetX).up(offsetY);
+                    Block var8 = this.worldObj.getBlockState(blockPos).getBlock();
 
                     if (!var8.getMaterial().isSolid() && !BlockRedstoneDiode.isRedstoneRepeaterBlockID(var8))
                     {

The fix is in a build for mc1.9. Is there any chance that it will be backported to a patch for 1.8, or is 1.8 permanently bugged?

@Jeffry, not unless Mojang releases a 1.8.9 which is unlikely.

laugexd

migrated

Confirmed

fall, painting, pop

Minecraft 14w05b, Minecraft 14w11b, Minecraft 14w20b, Minecraft 14w28b, Minecraft 14w32b, ..., Minecraft 1.8, Minecraft 1.8.1-pre5, Minecraft 1.8.1, Minecraft 1.8.2-pre1, Minecraft 1.8.8

Minecraft 15w37a

Retrieved