[MC-7569] RCON output has newlines removed

When executing rcon commands, the response is all in one string with no newline characters, even when the command yields several lines of text when executed on the console.

Bukkit returns the newlines, but vanilla Minecraft does not, making the server response much harder to parse.
Suggest either null-splitting or \n-splitting the lines.

Code analysis can be found by @unknown in this comment.

Comments 26

Fredrik Vold 2013-03-18T19:35:31Z

Yes, this affects 1.5 as well. Exactly the same, no changes at all.

Max Mayr 2013-07-11T10:15:43Z

This is still an issue in 1.6.1 and 1.6.2

Talven81 2013-11-26T20:58:04Z

Is this still a concern in the current Minecraft version 1.7.2 / Launcher version 1.3.4 ? If so, please update the affected versions in order to best aid Mojang ensuring bugs are still valid in the latest releases/pre-releases.

Max Mayr 2013-11-27T22:35:52Z

Yes, the 1.7.2 server still returns unsplit strings

galaxy_2alex 2014-01-22T08:21:28Z

Is this still a concern in the current Minecraft version 1.7.4 / Launcher version 1.3.8 or later? If so, please update the affected versions in order to best aid Mojang ensuring bugs are still valid in the latest releases/pre-releases.

16 more comments

dx 2014-02-07T21:09:45Z

1.7.4 server is affected. Launcher is irrelevant. 14w06b server is affected too.

dx 2014-02-07T21:12:41Z

I suggest changing the subject to mention that unsplit means "newlines removed". It wasn't obvious enough at first sight.

Olle Kelderman 2014-05-06T14:48:27Z

Can confirm this for server version 14w18b (launcher version is irrelevant).
I don't think i have permission to edit the affected versions.. At least, i can't find a button to do so..

Deleted account 2014-07-09T14:52:08Z

Is this still a concern in the current Minecraft version 14w21b / Launcher version 1.4.4 or later? If so, please update the affected versions in order to best aid Mojang ensuring bugs are still valid in the latest releases/pre-releases.

user-f2760 2014-07-09T15:46:35Z

you mean 27b

Olle Kelderman 2014-07-10T14:04:11Z

I have just tested this with the latest snapshot currently available (14w28a). Still happening.

dx 2014-10-26T00:32:40Z

1.8.1pre3 server is affected. Launcher is irrelevant.

Can the title be changed to "RCON output has newlines removed" or similar? Please? Anyone? This title seriously is terrible.

galaxy_2alex 2014-10-26T09:15:13Z

Reopened, thanks.

@dx: I gave you reporter access, so you can change the ticket as you like.
@Original Reporter: If you want the ticket back and update it yourself, leave a comment.

galaxy_2alex 2016-09-26T22:26:05Z

Is this still a concern in the current Minecraft version? If so, please update the affected versions in order to best aid Mojang ensuring bugs are still valid in the latest releases/pre-releases. If this has been done, we can reopen the issue.

Keep in mind that the "Resolved"-Status on this ticket just means "Answered", and that we are waiting for further information on whether this issue still exists or not. It will be reopened as soon as the requested information has been delivered.

Olle Kelderman 2016-09-27T10:43:54Z

just tested this with "minecraft_server.1.10.2.jar", can confirm it is still an issue!

Daniel Hodgson 2017-01-12T12:28:42Z

1.11.2 still has this issue.

Come on guys, I know this isn't exactly a major feature, but this is such a stupid simple issue. The client already renders the console properly, so I find it hard to believe this would be a difficult bug to fix.

Seblor 2017-06-20T18:19:15Z

1.12 Still has missing newline markers.
I don't know how to add an affected version though.

Julian 2018-04-26T14:26:32Z

1.12.2 still has that issue

null 2018-07-03T05:12:40Z

_{Based on Minecraft 1.12.2 decompiled via MCP 9.40}

The class net.minecraft.network.rcon.RConConsoleSource mimics a command sender and records the messages sent to it. The sendMessage(ITextComponent) method in that class, which adds a chat message to the buffer, should add an additional newline.

Liam Fry 2018-09-22T18:53:49Z

1.13.1 still has this issue.

Marcus H 2018-10-26T15:48:15Z

Confirmed for 1.13.2, can we please fix this???

Altus 2020-03-07T21:27:57Z

Still a problem as of 1.15.2 on Windows 10

For example, when sending the command "op" with no accompanying username the following is returned

"Unknown commandop<–[HERE]"

When it should be

"Unknown command
op<--[HERE]"

This is very troublesome when executing commands that return a large number of lines, that are then not separated by line-breaks as they would be in game, or in the server console itself

Wisq 2020-06-10T17:29:28Z

This remains unfixed as of 1.15.2, but I asked the owner of the RCON newline fix mod if it could be updated for 1.15.2, and they just uploaded the 1.15.2 version (thanks!), so rcon is once again patched and working properly on my server.

It would be really nice to get this fixed at some point, though. I'm pretty sure it's just a one-line fix somewhere!

Mos Kullathon 2021-06-28T18:57:27Z

Still an issue on 1.17.

isXander 2022-04-05T11:22:42Z

Can confirm on 1.18.2

Code analysis

Based on yarn 1.18.2 mappings

In the class RconCommandOutput

public void sendSystemMessage(Text message, UUID sender) {
    this.buffer.append(message.getString());
}

The message is appended to the buffer. Without a line seperator. I suggest simply appending System.lineSeperator() to the buffer on each system message

public void sendSystemMessage(Text message, UUID sender) {
   this.buffer.append(message.getString()).append(System.lineSeperator());
}

Like this!

NopeProsOnly 2023-05-10T19:13:40Z

Can confirm for 1.19.4