mojira.dev
MC-84005

Book and quill doesn't save changes when edited in offhand

The bug

When a book is signed in the off-hand, when switched back to the main hand, it reverts back to a Book and Quill.

How to reproduce

  1. Get a Book and Quill

  2. Switch Book and Quill to off-hand

  3. Write in the book and sign it

  4. Switch the book back to the main hand using the F hotkey

Code analysis

Based on 1.11 decompiled using MCP 9.35 rc1

The problem is that the method net.minecraft.network.NetHandlerPlayServer.processCustomPayload(CPacketCustomPayload) only tests for the mainhand when it receives a MC|BEdit or MC|BSign CPacketCustomPayload packet.

Linked issues

Comments 8

Confirmed. Workaround: Manually taking the item out of the offhand slot in the inventory.

edit: No longer works.

Confirmed for 16w06a

Confirmed for 1.9.2

Confirmed for 1.12-pre5

Still issue in 1.12 pre-7
It appears this issue also affecting command given books incorrectly displaying scoreboard and entity selector syntax if opened for first time in off-hand. Tag {resolved:#} also incorrectly triggers to 1 in offhand when clearly not resolved.

@unknown, the issue you mentioned is MC-111328

Can confirm for MC 1.12.1.

Confirmed fixed in 18w30a.

Justin Johnson

(Unassigned)

Confirmed

Minecraft 15w31b, Minecraft 15w31c, Minecraft 15w32c, Minecraft 15w35b, Minecraft 15w40b, , Minecraft 1.12.1, Minecraft 1.12.2, Minecraft 18w11a, Minecraft 18w19b, Minecraft 1.13

Minecraft 18w30a

Retrieved