mojira.dev
MC-8522

Pushing a button makes the button side textures look wrong

When pushing a button, the sides of it look like the button was squashed instead of being pushed into the wall.


Mod note: Fix from MC-90456 by @unknown

Button not pressed the textures are:

"north": { "uv": [ 5, 14, 11, 16 ], "texture": "#texture" },
                "south": { "uv": [ 5, 14, 11, 16 ], "texture": "#texture" },
                "west":  { "uv": [ 6, 14, 10, 16 ], "texture": "#texture" },
                "east":  { "uv": [ 6, 14, 10, 16 ], "texture": "#texture" }

However when pressed they change to:

"north": { "uv": [ 5, 15, 11, 16 ], "texture": "#texture" },
                "south": { "uv": [ 5, 15, 11, 16 ], "texture": "#texture" },
                "west":  { "uv": [ 6, 15, 10, 16 ], "texture": "#texture" },
                "east":  { "uv": [ 6, 15, 10, 16 ], "texture": "#texture" }

This causes the impression the button is pressed but the texture has jumped, the front sides of the button changes to the back sides texture when it's pressed.

Example: Wall, back px 1, front px 2, Air
W12A < button not pushed
W1A < button pushed default 1.8+ mc (looks weird)
W2A < what it now looks like with this fix (outer texture moves in towards wall for duration of press event)

The fix is to change the texture on the pressed button to:

"north": { "uv": [ 5, 14, 11, 15 ], "texture": "#texture" },
                "south": { "uv": [ 5, 14, 11, 15 ], "texture": "#texture" },
                "west":  { "uv": [ 6, 14, 10, 15 ], "texture": "#texture" },
                "east":  { "uv": [ 6, 14, 10, 15 ], "texture": "#texture" }

And the front edge texture moves towards the wall when the button is pressed and out as the button returns to normal.

Hope this is a simple bug to fix... (See attached

[media]

for the fix.)


In time order,

[media]

<- Unpressed Buttons

[media]

<- Current buttons pressed note the side texture.

[media]

<- Corrected version front texture moves closer.

The original has the near block texture jumping forward to remain visible, whereas with this suggested fix, it looks like the button actually moves as the near block texture seems to go into the block.


Just added a Resource Pack version of my fix, called

[media]

Hope this helps make testing the fix easier.

Linked issues

Attachments

Comments 14

It just seems like the model is one unit smaller, so only one row of pixels of the side texture is rendered.

Confirmed for 14w18b.

Giving this ticket to @unknown since reporter seems to be inactive.

4 more comments

Excuse me, @unknown
Would I be able to get permission to let users have the resource pack hotfix for their 1.8.x versions?
I'd happily replace my game name with a Mojang listing in the zip's pack.mcmeta, please let me know if this would be acceptable to mojang,
And thanks in advance.

You want to distribute a resource pack containing your own model? Of course you can do that.

[media]

is a tweaked version of a mojang/minecraft core/vanilla file,
I believe that I cannot release a changed Mojang file without their permission,
Therefore my request for permission above.

The only reason I attached

[media]

to this is because it would help with testing, as a resource pack it could be added and removed with the game running, allowing for easier testing of both the vanilla and fixed buttons.

There are plenty of resource packs out there that change vanilla models/textures, I think you'll be fine.

Ok, thanks.
(And the request is logged here should it be needed for future reference.)

Tim Craftor

John Hughes

Erik Broes

Confirmed

button, rendering, texture

Minecraft 1.4.7, Snapshot 13w04a, Minecraft 1.5, Snapshot 13w11a, Minecraft 1.7.4, ..., Minecraft 1.8, Minecraft 1.8.1-pre3, Minecraft 1.8.8, Minecraft 15w41b, Minecraft 15w44a

Minecraft 15w44b

Retrieved