mojira.dev
MC-92106

ThrownPotion not using particles from CustomPotionEffects tag

The bug

When a splash or lingering potion with the CustomPotionEffects tag hits the ground and bursts, it will only show the particles of the potion defined by the Potion tag.

This is pretty inconsistent as for example tipped arrows show the particles of the effects provided in the CustomPotionEffects tag.

Used command

/give @p lingering_potion 1 0 {CustomPotionEffects:[{Id:12,Duration:1200,Ambient:1b,Amplifier:1}],Potion:"minecraft:water"}

The reason

The following is based on decompiled version of Minecraft 1.9 using MCP 9.24 beta. All method and class names are the names used in the decompiled version.

The reason why this happens is because the method net.minecraft.client.renderer.RenderGlobal.playAuxSFX(EntityPlayer, int, BlockPos, int) only passes a data value. This is currently used to represent the id of a default potion. As MC-45749 shows this method might be outdated.

Linked issues

Attachments

Comments

[Mod]Les3awe

Confirmed for 16w03a

SunCat

This is fixed (don't know when) for potions with "potion" tag and could be WAI for uncraftable ones (as it's consistent with the color of the bottle)

migrated

Fixed in 16w39.

marcono1234

(Unassigned)

Confirmed

particle, potion

Minecraft 15w44b, Minecraft 15w45a, Minecraft 16w03a, Minecraft 16w04a, Minecraft 1.9, ..., Minecraft 16w39a, Minecraft 16w39b, Minecraft 16w39c, Minecraft 16w40a, Minecraft 16w41a

Minecraft 16w42a

Retrieved