[MC-98320] deadmau5's ears are offset while sneaking and while flying with elytra

The bug

When a player named "deadmau5" sneaks or flies with an elytra (and rotates his head), his ears are offset.

How to reproduce

Copy the latest version folder in the .minecraft\versions directory and append _custom to the copied name, resulting in for example 1.12-pre5_custom
Delete the .jar file inside the folder
Append _custom to the version .json file name as well

Replace the content of the version .json file with the following

{
  "id": "#VERSION#_custom",
  "time": "2038-01-19T03:14:07+00:00",
  "releaseTime": "2038-01-19T03:14:07+00:00",
  "type": "snapshot",
  "minecraftArguments": "--username deadmau5 --version ${version_name} --gameDir ${game_directory} --assetsDir ${assets_root} --assetIndex ${assets_index_name} --uuid 1e18d5ff643d45c8b50943b8461d8614 --accessToken ${auth_access_token} --userType ${user_type} --versionType ${version_type}",
  "inheritsFrom": "#VERSION#",
  "jar": "#VERSION#"
}

Replace all occurrences of #VERSION# with the version id you created a copy of, for example 1.12-pre5
Select this version in the launcher and start the game
Switch to third person view (F5) and sneak

Code analysis

^by@unknown

The method net.minecraft.client.renderer.entity.layers.LayerDeadmau5Head.doRenderLayer() doesn't check if the to be rendered entity is sneaking. Thus, a simple way to fix the sneaking issue would be to add that specific check, which translates the ears a bit down. (I don't know the exact "sneak-shrink"-value, 0.25F is just an example!)

net.minecraft.client.renderer.entity.layers.LayerDeadmau5Head.doRenderLayer()

// ...
if(entitylivingbaseIn.isSneaking()) {
	GlStateManager.translate(0F, 0.25F, 0F);
}
float f2 = 1.3333334F;
GlStateManager.scale(1.3333334F, 1.3333334F, 1.3333334F);
this.playerRenderer.getMainModel().renderDeadmau5Head(0.0625F);
// ...

The fix I found for the elytra-flying issue is very similar to my proposed fix on MC-75279 – clamping the pitch of the ears does the job. Again, the values (-30F, -60F) are only examples, there may be other, way better values to use here.

net.minecraft.client.renderer.entity.layers.LayerDeadmau5Head.doRenderLayer()

// ...
float f1 = entitylivingbaseIn.prevRotationPitch + (entitylivingbaseIn.rotationPitch - entitylivingbaseIn.prevRotationPitch) * partialTicks;
GlStateManager.pushMatrix();
if(entitylivingbaseIn.isElytraFlying()) {
	f1 = MathHelper.clamp(f1, -60F, -30F);
}
// ...

Note: I do not own the username "deadmau5" neither do I know the person owning it personally. The attached screenshots were created by using "deadmau5" as username. The screenshots were taken for testing purposes.

Linked issues

relates to 1

MC-52178 Cape doesn't move down while sneaking / Cape detaches from body while sneaking Resolved

Attachments

Deadmau5 ears offset sneaking (1.9-pre4).png

Comments 16

[Mod] redstonehelper 2016-02-29T13:54:59Z

What happens when gliding?

Jan Ziegler 2016-03-03T15:00:24Z

good question 😃

marcono1234 2016-03-03T16:15:09Z

Yes, they are offset when you rotate your head (pitch) while flying. The look also pretty strange when you rotate your head very fast.

maggstrom 2017-10-08T18:59:14Z

Confirmed in 1.12.2

muzikbike 2018-10-17T23:14:31Z

Does this affect swimming?

6 more comments

FaRo1 2018-10-18T19:48:35Z

I can't reproduce it with the steps in the description, I don't turn into DeadMouse. Tried with 1.13.1.

dejordzta incognito 2019-07-27T09:32:40Z

I have found through testing that this can be remedied and fixes the odd way the ears render, through changing the code a little more drastically. I'm not sure when this change came in to play and broke the mau5 ears, but I image it was since layers were introduced.

Note: I created a entirely new Layer to test and fix this. customMau5Ears is simply a new ModelRenderer, and LayerCustomMau5Ears is the entirely new class.

To fix this I first changed the way mau5 ears are created in ModelPlayer to add two boxes as follows:

// ...
this.customMau5Ears = new ModelRenderer(this, 24, 0);
this.customMau5Ears.addBox(1.5F, -10.5F, -1.0F, 6, 6, 1, modelSize);
this.customMau5Ears.addBox(-7.5F, -10.5F, -1.0F, 6, 6, 1, modelSize);
this.customMau5Ears.setRotationPoint(0.0F, 0.0F, 0.0F);
// ...

This creates two separate boxes at the correct positions, rather than creating one box and rendering it twice; this is what creates the odd rotations when you rotate your head quick enough.

Second, I duplicated the renderDeadmau5Ears function to the following:

public void renderCustomMau5Ears(float scale) {
    GlStateManager.scale(1.3333334F, 1.3333334F,1.3333334F);
    this.customMau5Ears.render(scale);
    GlStateManager.scale(1.0F, 1.0F, 1.0F);
}

This takes the scaling from the original LayerDeadmau5Ears class and handles it here; I guess it really wouldn't matter exactly where this is called.

Third, I made sure the angles were replicated from the head, and set the layer to invisible in the setInvisible function:

// ...
copyModelAngles(this.bipedHead, this.customMau5Ears);
...
this.customMau5Ears.showModel = invisible;
// ...

Fourth, I created a brand new Layer class that simply implements the LayerRenderer class:

public class LayerCustomMau5Ears implements LayerRenderer<AbstractClientPlayer> {
    private final RenderPlayer playerRenderer;

    public LayerCustomMau5Ears(RenderPlayer playerRendererIn) {
        this.playerRenderer = playerRendererIn;
    }

    public void doRenderLayer(AbstractClientPlayer entitylivingbaseIn, float limbSwing, float limbSwingAmount, float partialTicks, float ageInTicks, float netHeadYaw, float headPitch, float scale) {
        if (entitylivingbaseIn.hasSkin() && !entitylivingbaseIn.isInvisible()) {
                this.playerRenderer.bindTexture(entitylivingbaseIn.getLocationSkin());

            if(entitylivingbaseIn.isSneaking())
                GlStateManager.translate(0F, 0.2F, 0F);
            this.playerRenderer.getMainModel().renderCustomMau5Ears(0.0625F);
        }
    }

    public boolean shouldCombineTextures() {
        return true;
    }
}

Lastly, I instantiated this new layer in RenderPlayer:

// ...
this.addLayer(new LayerCustomMau5Ears(this));
// ...

The ears are now fixed; they stick to the head as they used to/should do and I haven't noticed any bugs i.e when sneaking or gliding.

Oval 2019-07-27T21:39:13Z

Confirmed for 1.14.4. Also affects swimming animation.

pulpetti 2020-07-19T15:01:46Z

Still in 1.16.1 and 20w29a

[Mod] markderickson 2020-09-21T22:54:05Z

Hello!
I can confirm for release 1.16.3. Can I request ownership to keep the ticket updated?

[Mod] markderickson 2020-11-07T14:50:09Z

I can confirm in snapshot 20w45a.

[Mod] markderickson 2020-11-07T17:14:51Z

I can confirm for 1.16.4 too. Also, I'd like to request ownership to keep the ticket updated.

marcono1234 2020-11-07T20:59:35Z

Thanks, you are now the reporter @unknown.

[Mod] markderickson 2020-11-07T21:18:05Z

Thank you! 🙂

MrMelon54 2021-07-10T15:23:38Z

I can confirm for 1.17. Why won't you fix it?

FaRo1 2021-07-10T15:36:15Z

Because it's a joke feature. No serious project manager would prioritise this over anything else. The time it would take to fix it would not be spent on actually useful things.