Finally, an assignee! Thank you, Brandon
@eclipseisoffline This may not be the place to ask, but idk where else to go, but can I persuade you to port your mod to 1.20.1 Forge?
@eclipseisoffline First of all, bless you for this. Secondly, if the mod doesn't need to be installed on client, how can it work on Singleplayer worlds? I don't play on servers that use Fabric.
I don't know if anyone else has this issue, or if this is related (although I'm sure it is) but, because the freeze/lag from opening/breaking a chest with a buried treasure map in it is so bad, the map itself is loaded as an empty map. It still has the title "Buried Treasure Map", but when it's held in the player's hand, it's displayed as an empty, unused map. When right-clicking, it acts like an empty map and shows the area around the player, completely removing the functionality of it being a treasure map.
I've noticed this just now while playing 1.20.1. But I swear that last month, I was playing on a Survival world in the same version (although it was initially created in 1.20) but this was not an issue at all for me then. So I don't know at all what causes the lag or the failure of the map being properly a buried treasure map.
In case it has any impact, I always set my render distance to 16 and my simulation distance to 12. I do play with OptiFine and/or Fabric, but I've tried loading in a completely vanilla client and it all persists regardless.
Probably some helpful info: this is fixable. I remember when the Better Together Update for Bedrock came out, the hopper mechanics for discs and jukeboxes were implemented, AND the tracks were not abruptly cut off if they were longer lengths than default. Of course, it's bugged now in Bedrock and in Java. And with no mods available to fix, we sort of have to pray that someone notices this and decides to fix. I hope this information helps, not that it will speed things up probably.
Given that this is a Bedrock bug as well, you may be right. I could've sworn that this wasn't always a bug on Bedrock since it was added, but looking at the related bug report, apparently I've been mistaken, and it's been an issue ever since hopper/jukebox mechanisms were added. On the topic of this Java bug, I agree that, if no hoppers are placed under the jukebox, the track should play indefinitely. But since this has never been correctly implemented in Java or Bedrock since the mechanism has been added, I'm not so sure it'll happen soon. We'll just have to wait and see.
Confirmed for 1.20-pre5. I now know why the lengths of discs are hard-coded and come to a dead stop at that time. This is all unfortunately as intended.
As part of Bedrock parity, when a music disc reaches the end of its track, it wants to allow for any other music discs to enter seamlessly, specifically through a hopper, as the current music disc is ejected. To replicate the goal:
1. Place a hopper, place a jukebox directly above it, and place another hopper connected to the jukebox.
2. Place two music discs into the hopper going into the jukebox. One disc will immediately begin playing, the other will remain in the hopper.
3. Once the first music disc has reached the end of its hard-coded length, it will immediately stop playing, and make its way to the hopper below the jukebox. Simultaneously, the second disc from the other hopper will be inserted and immediately start playing.
As you can guess, the game certainly doesn't care how long each record of the client's resource pack is, as each client can be on the same world with different packs with different lengths for a certain disc. That's why the lengths of the records are hard-coded, so that the mechanics of being swapped in/out of jukeboxes is the same for everyone. It undisputedly sucks that we have to kiss the idea of custom-length music discs goodbye, as it's been a staple since 2013 with Minecraft 1.6 allowing custom audio, but it is what it is. Hopefully there may be mods out for anyone who wants to bring back the old mechanics.
Still a problem in 1.20 pre2.
Confirmed for 23w18a.
Was this issue present in 1.19.3, when bedrock parity to the jukeboxes? I'm wondering if, along the way, the lengths of the discs were somehow hard-coded, forcing custom music to come to a dead stop. Would be nice to have an assignee right about now.
Can confirm for 21w43a, for the following structures and mobs:
Ocean Monuments (Guardians do not spawn, Elder Guardians do)
Pillager Outposts (Pillagers do not spawn, Iron Golems might, Pillagers do spawn in raids, I'm not sure if patrols still occur)
What DOES work:
Bastion Remnants (Both Piglins and Piglin Brutes spawn, as well as Hoglins in Hoglin stables)
End (The Ender Dragon spawns, as do the pillars with Ender Crystals)
End Cities (Shulkers spawn)
Fortresses (Zombified Piglins, Wither Skeletons, Blazes, and Magma Cubes all spawn)
Igloos with Basements (both a Villager and a Zombie Villager spawn)
Mansions (Vindicators and Evokers both spawn)
Ocean Ruins (Drowned spawn)
Raids (Vindicators, Evokers, Witches, Pillagers, and Ravagers can all spawn)
Swamp Huts (Both a Witch and a black Cat spawn)
Villages (Villagers spawn)
Grey Areas:
Shipwrecks (I could swear Drowned spawn here before, but I might be mistaken)
The way the discs are sorted is based on how much they power a redstone comparator. In the order they had before the otherside music disc was added, the went up sequentially from a signal of 1 to a signal of 13. Since they added the otherside disc (signal 14), it has come BEFORE pigstep (signal 13), which isn't right based on the current order. The pigstep and otherside placements in the creative menu should be swapped. Confirmed for 21w43a.
I got the exact same problem here
I am unable to reproduce as well, in 1.17.1. So I believe this bug is fixed. 🙂
It made me pick a version, it started on 1.17.
And on one has a problem like this
For some reason my only crash reports are for clients...
Ok, but I use the normal Minecraft Launcher but sometimes I use the Lunar Client
ok I added it
Bless y'all for the fix, but if I'm to understand correctly from the changelog in 24w21a, this bug can only be fixed if you're using a datapack that accepts the extended lengths of the custom songs? Just tried in 1.21-pre1 and my custom song cut abruptly again. I'm sure that this is intended, but I'm still hoping for clarity on what to do so that the songs may be fully played without the use of mods.