modmuss50

Can confirm this is an isssue still in 1.16-pre2, this does not effect 1.14.4 as the issue current states.

Looking at the code it seems the field for the front left fin is never added into the Iterable list of model parts to be rendered. Also seems the rear left spikes are being added into that list twice. The issue most likely came about in 1.15 with the entity rendering changes.

Should be a trivial fix.

This bug seems to have been added in 22a. When updating fabric it caused our command tests to fail.

The fix seems trivial (Talking in official mojang names):

In Minecraft.selectLevel, ServerResources.loadResources is called with true being passed as the 2nd argument, this should be false, as its being ran on the intergrated server. This boolean is only used when true to enable the dedicated server commands (such as Ban and Stop). I created a mixin [gist|https://gist.github.com/modmuss50/8a65868faa5d4a0ffe60649b16a06153] to change this and validated that it fixed the issue.

I have repoduced this in 20w21a, however it was only logged to console and didnt crash the game. I still believe the hard crash can still happen as the code appears untouched since it was last reproduced in 20w18a.

Confirmed to still be an issue in 20w15a

I will be using yarn names throught this comment:

I spent sometime looking into the best way of fixing this. I came to the conclusion that using Collections.synchronizedMap() is the ideal fix. The reason for using this over ConcurrentHashMap is HashMap allows null values, where as ConcurrentHashMap does not, this is important as in getStructureOrBlank a null map value is possible if the structure could not be found, synchronizedMap does not change the implimentation details of HashMap.

The mixin linked above is the old method, [StructureManagerMixin.java|https://github.com/modmuss50/Voyager/blob/master/src/main/java/me/modmuss50/voyager/mixin/StructureManagerMixin.java] shows how I achieved this using Collections.synchronizedMap()

This is on a basicly brand new MacBook Pro running Mac OS without any antrivirus or parental controls enabled. 

I have just tried deleting the libraries directory to force it to try to re-download the libs but that didnt help.

Leaving the Beta version of the launcher fixes the issue and the game launches as expected.

This worked fine on my local hosted server. Maybe the server ran out of ram.