mojira.dev
MC-116875

'Local Brewery' advancement is not restricted to potions

The Bug

Local Brewery advancement can be obtained by pulling water bottles out of a brewing stand.

Steps to reproduce

Make sure that you do not have the advancement 'Local Brewery':

/advancement revoke @p only minecraft:nether/brew_potion
  1. Put a water bottle in a brewing stand.

    /item replace block <pos> container.2 with minecraft:potion[minecraft:potion_contents=water]
  2. Get the bottle out of there.
    →❌ You get the advancement 'Local Brewery'.

Expected result

Local Brewery advancement should only be received by pulling actual potions out of a brewing stand.

Actual result

You can put a water bottle in a brewing stand and immediately pull it out to get the advancement.

Linked issues

MC-118204 Advancement 'Local Brewery' Given when placing and taking an empty bottle from the brewing stand. Resolved MC-118635 Skip advancement 'Local Brewery' Resolved MC-136228 Local Brewery Advancement if you put in and take out empty bottles Resolved MC-143089 Taking glass bottle from brewing stand gives Local Brewery Advancement Resolved MC-150371 Grabbing water bottle from output of brewing stand gives Local Brewery advancement Resolved

Attachments

Comments 25

What would be the intended behaviour? Only granting when removing valid potions (i.e. non water/empty bottles)?

Or something more complex where you check if the player actually started the brewing process?

@unknown,
The former happened after fixing MC-108877
The latter is not valid with MC-88501 being WAI

This makes the advancement possible without even brewing anything, you just put a bottle in then right after take it out.

This bug is still existent in 1.16.1

Can confirm in 20w48a.

15 more comments

Can confirm in 1.20.4

Seems to be fixed in 1.20.5, now requires the item to be minecraft:potion, minecraft:splash_potion or minecraft:lingering_potion.

Still applies to a water bottle

@crazysmc water bottles are technically potions.

JUE13

(Unassigned)

Confirmed

Gameplay

Low

Advancements

advancement, brewed_potion, glass_bottle, potion

Minecraft 17w17a, Minecraft 17w17b, Minecraft 17w18a, Minecraft 17w18b, Minecraft 1.12 Pre-Release 1, ..., 1.21, 1.21.1, 1.21.5 Pre-Release 1, 1.21.5, 1.21.6 Pre-Release 3

Retrieved