[MC-218528] Turtle eggs can become broken by placing them in the same block as some already broken eggs

The bug

When one turtle egg is cracked, you can place more on the same block and they will be cracked, too.

To reproduce

Reproduction steps provided by @unknown:

Generate world
Use command /setblock ~ ~ ~ minecraft:turtle_egg[eggs=1,hatch=1]
Grab Turtle Egg from inventory
Place another egg by right-clicking
Observe issue

Code analysis

Code analysis and fix by @unknown can be found in this comment.

Attachments

MC-218528.mp4

Comments 17

Moesh 2021-03-10T12:59:46Z

Repro steps

Generate world
Use command /setblock ~ ~ ~ minecraft:turtle_egg[eggs=1,hatch=1]
Grab Turtle Egg from inventory
Place another egg by right-clicking
Observe issue

Avoma 2021-03-12T17:32:13Z

Video attached. Also affects 21w10a.

bugsbugsbugs 2021-03-12T17:58:50Z

With the block states that turtle eggs have it isn’t possible to fix this. Fix would require making different turtle eggs on the same block have different hatch states somehow.

JuniorJedi256 2021-03-14T17:00:25Z

Or, another option would be to not let players place turtle eggs on cracked turtle eggs.

Avoma 2021-03-21T14:00:49Z

Can confirm in 21w11a.

7 more comments

Avoma 2022-03-10T16:16:57Z

Can confirm in 1.18.2.

Avoma 2022-07-23T15:30:55Z

Can confirm in 1.19.

Avoma 2022-08-31T15:55:37Z

Can confirm in 1.19.2.

ampolive 2022-09-01T00:20:12Z

I believe the easiest fix would be to just disallow placing turtle eggs on already hatched turtle eggs. This could be done by adding a new condition to check the HATCH value inside TurtleEggBlock#canBeReplaced(...):

...
    @Override
    public boolean canBeReplaced(BlockState $$0, BlockPlaceContext $$1) {
        if (!$$1.isSecondaryUseActive() && $$1.getItemInHand().is(this.asItem()) && $$0.getValue(EGGS) < 4 && $$0.getValue(HATCH) == 0) {
            return true;
        }
        return super.canBeReplaced($$0, $$1);
    }
...

Brain81505 2023-01-15T06:41:01Z

Can confirm in 1.19.3