Prior to 23w32a, armor trims rendered their second layer. Now only the first layer renders, and the rest of the texture is ignored.
In the attached screenshots, the helmet with wings is from 23w31a, and the one without is the same texture in 23w32a. I've also attached the trim texture for reference so you can see the area that is now being ignored.
This was something that was great for resource packs, so if it's intentional, I really urge you to reconsider this change.
Linked issues
Attachments
Comments 7
In my experience, submitting feedback through the official feedback site is not a productive use of time. If the developers respond to this report by closing it as Works as Intended, so be it.
This seems like a pretty over-the-top fix for a very minor cosmetic problem that could have been solved by editing the helmet textures in question rather than limiting what resource pack makers are capable of doing, but I can't say I feel particularly inclined to argue with the devs if this is how they decide the issue should be solved.
This is a significant difference from 23w31a, so i see this as a valid issue. The fix for MC-259982 and MC-263338 didn't account for resource packs that use custom armor trims, and makes it almost impossible to have custom armor textures that are independent of that of the base texture, which makes this a remarkable downgrade from how it worked in 1.20.1:
[media][media]
Hopefully this is not intended, as this would make resource pack creators need to opt back to the use of core shaders due to a fix for a seemingly very minor issue.
It's a deliberate choice for the fix, asking for a change (even if just for resource packs (eg via a mcmeta file)) is a feature request, not a bug.
@unknown, it may well be an unintended consequence of the fix, which would, in fact, make it a bug. We are not demanding a specific solution as you seem to be implying, we're pointing out that it's happening. Whatever happens after that point is up to the devs.
I did not mean to imply that, I always say things as I mean them, no beating around the bush nor sugarcoating (I don't intent to waste people's time just for them to figure out what I mean).
I merely mean that fixing this can go in 2 ways:
revert the change in trim texture merging logic
make the trim texture merging logic toggleable (which would need to be via a texture mcmeta file), even if vanilla textures don't use that toggle
Don't get me wrong, I'd absolutely prefer being able to add pixels, rather than just change, but I don't see any logical reason to believe the change in texture applying (which, I should note, is completely unique to armor trims, and as such, new code) is a bug.
Seems like the fix for MC-259982 did this: only allowing the trim overlay on existing armor pixels. Since the armor has no second layer pixels, the trim doesn't render them.
As a result, this is intended, and requesting to change it should be done at feedback.minecraft.net.