mojira.dev
MC-278324

Inconsistent results when an item that checks for a player context_entity_type is in a GUI or menu screen

 
When using an item model that changes based off the context_entity_type property checking for a player, the result is very inconsistent between various GUIs and screens in the game that render or hold items.  Below is a table documenting the different screens/GUIs, whether or not items within them consider the player as the context entity, whether or not this seems intended or correct, and any additional notes on the behavior. 

 

Screen/GUI

Considered as held
by a player?

Likely to be correct?

Additional notes

Toasts

No

Yes

 

Advancements

No

Yes

 

Statistics

No

Yes

Seems to be intended as the resolution to MC-8550

World Creation

No

Yes

 

Gamemode Switcher

Yes

No

Seems likely to be incorrect based on the other non-block UI screen behaviors.  Not a tangible item.

Recipe Book Tabs

No

Yes

Seems to be intended as the resolution to MC-116293

Creative Menu tabs

Yes

No

Inconsistent with the recipe book tabs.  Seems to be unintended, as MC-182892 is confirmed but unresolved.

Recipe Book recipes

Sometimes

Mixed results

  • Recipes with a single item displayed in the slot are not considered as player context.  Seems intended as the resolution to MC-116293

  • Recipe slots with 2 stacked items treat the top as not player context and the bottom as player context.  This one is the weirdest case on this list.

  • The crafting grids in the expanded recipe previews for items with many recipes are treated as player context.  This is consistent with the behavior for the full size grids, but inconsistent with the other recipe book items and unknown if intended, as these items are intangible.

Crafting Table/Crafter input slots

Yes

Uncertain1

 

Crafting Table/Crafter output slots

No

Yes

Seems to be intended as the resolution to MC-186797

Missing ingredient recipe displays

No

Yes

Not a tangible item, seems likely to be correct.

All Anvil slots

Yes

Uncertain1

 

All Brewing Stand slots

Yes

Uncertain2

 

Beacon payment slot

Yes

Uncertain1

 

Beacon payment example items

Yes

No

Not a tangible item.

All Furnace, Blast Furnace, and Smoker slots

Yes

Uncertain2

 

All Loom slots

Yes

Uncertain1

 

All Smithing Table slots

Yes

Uncertain1

 

All Cartography Table slots

Yes

Uncertain1

 

All Grindstone slots

Yes

Uncertain1

 

Stonecutter

Yes

Mixed Results

The selectable recipes are not tangible items, but the input and output slots should follow note 1.  Currently all three considered the player as the context entity type.

Items in container blocks, such as Chests, Barrels, and Shulker boxes

Yes

Uncertain2

 

Items in the equipment/storage slots of Horses, Mules, Donkeys, and Llamas

Yes

Uncertain2

 

Items in the Bundle tooltip/preview

Yes

Uncertain, likely yes

 

Villager/Wandering Trader trades list

No

Yes

Seems to be intended as the resolution to MC-182888

Villager/Wandering Trader input/output slots

Yes

No 

Seems to be unintended, MC-186849 is unresolved but confirmed, and relates to MC-182888

 

 
1 - Entirely depends on if items placed in GUI slots still considering the player as their context entity is intended behavior.

2 - Depends on if storage/container slots are intended to be treated differently from slots in GUIs that don't hold items when closed, unlike the ones covered by note 1.

 

Attached are screenshots of the cases listed in the chart.  The item model being an apple means that it is considered as player context, and the item model being a potato means that it is not.  The resource pack used to test this is also attached - various random items were used to test the different cases, so refer to the files at assets/minecraft/items to see which are changed.

Linked issues

Attachments

Comments 6

Please update with the latest changes and clarifications in 1.21.4-pre1.

Updated to match the changes in pre1, including a new version of the resource pack.  None of the cases listed in the table changed behavior, however the changelog gave clarification on a few of them, so I've linked any relevant reports in the additional notes for the case.  

Also applies using something with the death_protection component (e.g. totem)

Using an item with death_protection component

No

Yes

 

My previous comment’s table was wrong. It is not likely to be correct. Unfortunately I cannot edit my previous comment so I have to post a new one.

Using an item with death_protection component

No

No

 

CarterJohnson374

(Unassigned)

Confirmed

Platform

Normal

Items, Resource Packs

item, item-model, resource-pack

24w46a, 1.21.4 Pre-Release 1

Retrieved