After switching game modes using F3+F4, you need to press F3 twice to toggle the debug screen

Can confirm in 20w51a.

Can confirm in 21w03a.

Confirm in 21w06a

Affects 21w11a.

Can confirm in 21w13a

Can confirm in 21w15a

Can confirm in 1.17.

Can confirm 1.17.1

Can confirm this behavior in 21w42a. Here are some extra details regarding this problem.

The Bug:

After using the gamemode switcher, you are required to press the F3 key twice in order to enable the debug menu.

Steps to Reproduce:

• Open the gamemode switcher and switch into any gamemode. (Hold F3 and press F4 to bring up this menu and to navigate between gamemodes).

• Hit the F3 key in an attempt to enable the debug menu.

• Take note of whether the F3 debug menu is enabled.

• Hit the F3 key again.

• Take note as to whether or not the F3 debug menu is now enabled.

Observed Behavior:

After using the gamemode switcher, you are required to press the F3 key twice in order to enable the debug menu.

Expected Behavior:

After using the gamemode switcher, you would not be required to press the F3 key twice in order to enable the debug menu. Instead, you should only have to press the F3 key once in order to enable the debug menu after using the gamemode switcher.

Can confirm this behavior in 21w44a

Can confirm, as well, in 1.18 Pre-Release 1

Can confirm in 1.18 rc1

Can confirm in 1.18.1.

Affects 22w03a.

Affects 22w07a.

Affectx 1.18.2-pre1.

Affects 22w11a.

Code analysis

(placed in the comments to avoid crowding the description)

net.minecraft.client.Keyboard.java (22w11a, Yarn mappings)

if (this.client.currentScreen == null || this.client.currentScreen.passEvents) {
            InputUtil.Key bl = InputUtil.fromKeyCode(key, scancode);
            if (action == 0) {
                KeyBinding.setKeyPressed(bl, false);
                if (key == 292) {
                    if (this.switchF3State) {
                        this.switchF3State = false;
                    } else {
                        this.client.options.debugEnabled = !this.client.options.debugEnabled;
                        this.client.options.debugProfilerEnabled = this.client.options.debugEnabled && Screen.hasShiftDown();
                        this.client.options.debugTpsEnabled = this.client.options.debugEnabled && Screen.hasAltDown();
                    }
                }
            }
. . .
}

This if-statement is responsible for toggling on and off the debug menu when F3 is released. However, this.client.currentScreen == null is false when F3 + F4 is pressed because it pulls up a screen. In this case, the release of the F3 key is not detected because the screen remains open until after it is released, and thus this.switchF3State remains set to true. This is why it takes two more presses of F3 to toggle the menu.

A potential easy fix for this would be to change the following code earlier in net.minecraft.client.Keyboard.java#processF3() from

case 293: {
                if (!this.client.player.hasPermissionLevel(2)) {
                    this.debugLog("debug.gamemodes.error", new Object[0]);
                } else {
                    this.client.setScreen(new GameModeSelectionScreen());
                }
                return true;
            }

to

case 293: {
                if (!this.client.player.hasPermissionLevel(2)) {
                    this.debugLog("debug.gamemodes.error", new Object[0]);
                    return true;
                } else {
                    this.client.setScreen(new GameModeSelectionScreen());
                    return false;
                }
            }

to make sure this.switchF3State is never set to true when F3+F4 is pressed and succeeds.

Affects 22w12a (edit: and 22w14a).

Can confirm in 1.18.2 and 22w15a.

Affects 22w18a.

Affects 22w19a.

Affects 1.19-pre1.

Affects 22w42a

In 23w32a and in 1.20.1