[MC-62118] Iron bars model issues

The linings on the top/bottom edges should not appear when connected to other iron bars, see attached screenshots showing a comparison of 1.7 and 1.8.
The lining on the sides does not appear

Linked issues

is blocked by 1

MC-50817 differing states of bars/panes cause self culling Resolved

is duplicated by 7

MC-62932 top side of iron bar invisible when looking from inside Resolved

MC-67688 Iron Bars inproper connected textures Resolved

MC-72891 Iron fences render in an odd way Resolved

MC-83095 Iron bars have no texture on end face Resolved

MC-85811 Ugly iron bar graphical texture and texture is not a full block anymore! Resolved

2 more links

Attachments

jira_debug_insomniac_lemon_v2.zip

Comments 15

kumasasa 2014-07-21T06:12:18Z

Confirmed

user-f2760 2014-07-22T19:01:22Z

also confirmed for b snapshot

Christie N 2014-07-22T19:11:06Z

This seems to be a model problem. This is a more correct model:

{
	"ambientocclusion": false,
	"textures": {
		"particle": "blocks/iron_bars",
		"bars": "blocks/iron_bars",
		"edge": "blocks/iron_bars"
	},
	"elements": [
		{
			"__comment": "Bars",
			"from": [8,0,0],
			"to": [8,16,16],
			"faces": {
				"west": {
					"uv": [0,0,16,16],
					"texture": "#bars"
				},
				"east": {
					"uv": [0,0,16,16],
					"texture": "#bars"
				}
			}
		},
		{
			"__comment": "Top face",
			"from": [7,15.995,0],
			"to": [9,15.995,16],
			"faces": {
				"up": {
					"uv": [7,0,9,16],
					"texture": "#edge",
					"cullface": "up"
				},
				"down": {
					"uv": [7,0,9,16],
					"texture": "#edge",
					"cullface": "up"
				}
			}
		},
		{
			"__comment": "Bottom face",
			"from": [7,0.005,0],
			"to": [9,0.005,16],
			"faces": {
				"down": {
					"uv": [7,0,9,16],
					"texture": "#edge",
					"cullface": "down"
				},
				"up": {
					"uv": [7,0,9,16],
					"texture": "#edge",
					"cullface": "down"
				}
			}
		},
		{
			"__comment": "North face",
			"from": [7,0,0.005],
			"to": [9,16,0.005],
			"faces": {
				"north": {
					"uv": [7,0,9,16],
					"texture": "#edge",
					"cullface": "north"
				},
				"south": {
					"uv": [7,0,9,16],
					"texture": "#edge",
					"cullface": "north"
				}
			}
		},
		{
			"__comment": "South face",
			"from": [7,0,15.995],
			"to": [9,16,15.995],
			"faces": {
				"south": {
					"uv": [7,0,9,16],
					"texture": "#edge",
					"cullface": "south"
				},
				"north": {
					"uv": [7,0,9,16],
					"texture": "#edge",
					"cullface": "south"
				}
			}
		}
	]
}

as opposed to this:

{
    "ambientocclusion": false,
    "textures": {
        "particle": "blocks/iron_bars",
        "bars": "blocks/iron_bars",
        "edge": "blocks/iron_bars"
    },
    "elements": [
        {   "__comment": "bars",
            "from": [ 8, 0, 0 ],
            "to": [ 8, 16, 16 ],
            "faces": {
                "west": { "uv": [ 0, 0, 16, 16 ], "texture": "#bars" },
                "east": { "uv": [ 0, 0, 16, 16 ], "texture": "#bars" }
            }
        },
        {   "__comment": "sides",
            "from": [ 7, 0, 0 ],
            "to": [ 9, 16, 16 ],
            "faces": {
                "north": { "uv": [ 7, 0, 9, 16 ], "texture": "#edge", "cullface": "north" },
                "south": { "uv": [ 7, 0, 9, 16 ], "texture": "#edge", "cullface": "south" }
            }
        },
        {   "__comment": "top/bottom",
            "from": [ 7, 0.005, 0 ],
            "to": [ 9, 15.995, 16 ],
            "faces": {
                "down": { "uv": [ 7, 0, 9, 16 ], "texture": "#edge" },
                "up":   { "uv": [ 9, 0, 7, 16 ], "texture": "#edge" }
            }
        }
    ]
}

which puts multiple planes on the same cube, causing the error.

Jacob Mingear 2014-08-12T13:25:33Z

confirmed as of 14w32d

[Mod] redstonehelper 2014-10-14T18:36:14Z

Affects 1.8.

More info taken from MC-67688: The top lining will only render when viewed from above, the bottom lining will only render when viewed from below. Additionally, these linings should not appear when connected to other iron bars, see attached screenshot showing a comparison of 1.7 and 1.8.

5 more comments

Erik Broes 2015-10-24T20:24:36Z

1.9 models changed this ticket drastically.

If someone want to give a shot at an improvement for the 1.9 models feel free!

Meringue 2015-10-26T16:17:43Z

How about adding up/down conditions? Would of course cause a few more models.
Something like this (hope i get it right)...

iron_bars.json

{
    "multipart": [
        {   "when": { "north": false, "east": false, "south": false, "west": false, "up": false, "down": true },
            "apply": {  "model": "iron_bars_post_end_up" }
        },
        {   "when": { "north": false, "east": false, "south": false, "west": false, "up": true, "down": false },
            "apply": {  "model": "iron_bars_post_end_down" }
        },
        {   "when": { "north": false, "east": false, "south": false, "west": false },
            "apply": { "model": "iron_bars_post" }
        },
        {   "when": { "north": true, "east": false, "south": false, "west": false },
            "apply": { "model": "iron_bars_cap" }
        },
        {   "when": { "north": false, "east": true, "south": false, "west": false },
            "apply": { "model": "iron_bars_cap", "y": 90 }
        },
        {   "when": { "north": false, "east": false, "south": true, "west": false },
            "apply": { "model": "iron_bars_cap_alt" }
        },
        {   "when": { "north": false, "east": false, "south": false, "west": true },
            "apply": { "model": "iron_bars_cap_alt", "y": 90 }
        },
        {   "when": { "north": true },
            "apply": { "model": "iron_bars_side" }
        },
        {   "when": { "north": true, "up": false, "down": true  },
            "apply": { "model": "iron_bars_edge_up" }
        },
        {   "when": { "north": true, "down": false, "up": true  },
            "apply": { "model": "iron_bars_edge_down" }
        },
        {   "when": { "east": true },
            "apply": { "model": "iron_bars_side", "y": 90 }
        },
        {   "when": { "east": true, "up": false, "down": true  },
            "apply": { "model": "iron_bars_edge_up", "y": 90 }
        },
        {   "when": { "east": true, "down": false, "up": true  },
            "apply": { "model": "iron_bars_edge_down", "y": 90 }
        },
        {   "when": { "south": true },
            "apply": { "model": "iron_bars_side_alt" }
        },
        {   "when": { "south": true, "up": false, "down": true  },
            "apply": { "model": "iron_bars_edge_up_alt" }
        },
        {   "when": { "south": true, "down": false, "up": true  },
            "apply": { "model": "iron_bars_edge_down_alt" }
        },
        {   "when": { "west": true },
            "apply": { "model": "iron_bars_side_alt", "y": 90 }
        },
        {   "when": { "west": true, "up": false, "down": true  },
            "apply": { "model": "iron_bars_edge_up_alt", "y": 90 }
        },
        {   "when": { "west": true, "down": false, "up": true  },
            "apply": { "model": "iron_bars_edge_down_alt", "y": 90 }
        }
    ]
}

insomniac_lemon 2015-10-26T17:07:28Z

2D iron bars can't really be fixed with a plain model change because of MC-50817. To sum up the issue, what faces cause culling is hardcoded, the issue here is that any state of iron bars will cull any other state of iron bars (say, north only would cause culling on the top face of north-south).

If that wasn't an issue, simply adding culling to the top/bottom faces would restore 1.7's look. But that won't properly work unless the game knows only to cull when states match (or when they're smaller, like north-south can cull faces of north but not the other way around or north-east etc).

EDIT: I just noticed that the ticket also has pictures attached of bars viewed from the side looking extra odd because the side faces are missing, this actually could be fixed by making some models that would get used with multi-part only when there is only 1 connection. But that's not as much of an issue as top/bottom faces always showing is since that actually can't be fixed using a resource pack.

insomniac_lemon 2015-10-26T20:11:45Z

OK, so I've looked into it further, and fixing the sides is actually easier than I thought, also I found a UV issue.

The sides can actually be added in with the 'cap' models (iron_bars_cap.json and iron_bars_cap_alt.json)

The issue is on those same models, the 'alt' model has an incorrect texture mapping that makes it look odd. I've attached a resource pack that corrects both of these issues (there's a .txt file listing resource-related bugs, some of which the pack points out).

Swekob 2015-10-28T19:41:42Z

Confirmed for 15w44a.

Erik Broes 2015-11-09T21:28:34Z

Took in insomniac_lemon's suggestions.

The UV issue should also be fixed.

insomniac_lemon 2015-11-10T04:26:44Z

Grum, unless you have changed the culling system to *fix MC-50817 OR you implement up/down states as Meringue **suggested above then this issue is only half fixed.

People don't want to see horizontal faces through their iron bars or glass panes... (besides just being visually jarring and ugly, it differs from past behavior of iron bars/glass panes)

*= either detecting the state/model a block uses and only cause culling if it's a match/covers all faces... allowing culling on top/bottom faces without issue

**= so culling isn't needed here to have faces on the top/bottom but NOT on the inside... similar to the fix I employed which uses 1-connection states for the sides

[Mod] Neko 2015-11-12T20:10:48Z

Is the line in-between iron bars WAI? Because it's in 15w46a

insomniac_lemon 2015-11-21T11:28:07Z

I have updated my debug pack to show MC-50817 in action, as well as show iron bars without the line in them. 50817 is needed to be solved even for this issue to be fixable by resource packs.

Here is the pack:
https://bugs.mojang.com/secure/attachment/105321/jira_debug_insomniac_lemon_v3.zip

Minerdomera 2020-04-15T14:50:18Z

Top/Bottom model issues still present in 1.15.2/20w15a