[MC-63340] Sleeping always resets time until rain

The bug

When all players are sleeping and then woken up, rain and thunder times are always reset, regardless whether or not it was raining while the players were sleeping.

As a result, if you skip every night, you are very unlikely to ever experience rain or thunder, since the rain time is usually set to a value that is longer than a day (10 minutes).

How to reproduce

Reset weather
```
/weather clear 0
```
Pause the world (to save it) and inspect the rainTime and thunderTime values in the level.dat file using for example NBTExplorer or NBT Studio
Set time to night
```
/time set midnight
```
Sleep and wait until you are woken up
Repeat step 2
→ ❌ The values were changed to a random value despite it not raining or thundering

It would be expected for the weather to be reset only if it is currently raining/thundering.

Code analysis

Based on 1.12.2 decompiled using MCP 9.40

The method net.minecraft.world.WorldServer.wakeAllPlayers() always resets thunder and rain time.

Linked issues

is duplicated by 3

MC-151764 Weather seems to change to thunderstorm every 5 minutes. Resolved

MC-167256 In Realms, rainy weather and thunder happens doesn't stop. Sleeping will stop it for five minutes, before it restarts. Same with /weather clear. Resolved

MC-171098 Daily thunderstorms and very dark Resolved

relates to 1

MC-222596 Sleeping through thunderstorms resets time of day Open

Comments 22

Andrew McGowen 2014-07-24T02:01:01Z

Maybe this is why it always rains on the Mindcrack server 😛

Ezekiel 2014-07-25T02:30:59Z

This is intended functionality.

ChocolateChip Cookies 2014-07-25T13:31:29Z

Are you sure? It makes sense that sleeping would cause rain to stop – the idea is that the player sleeps, and then the rain is gone in the morning. However, sleeping when it's not raining shouldn't reset the timer (in fact, one would think that the timer would get smaller, because "the next morning" is closer to the scheduled rain time.

Has Mojang confirmed that it's intended? It's been in the game for awhile, but it could just be a long-standing oversight that no one has fixed yet.

Ezekiel 2014-07-25T13:32:19Z

I'm going to double check.

ChocolateChip Cookies 2014-08-05T04:20:09Z

Still exists in 14w31a.

12 more comments

MazeCraft 2014-09-24T19:58:55Z

It is still present in 1.8 release.

yut951121 2014-10-18T12:31:08Z

So if I sleep everyday it will never rain?

galaxy_2alex 2014-12-22T09:41:31Z

Is this still a concern in the current Minecraft version? If so, please update the affected versions in order to best aid Mojang ensuring bugs are still valid in the latest releases/pre-releases. If this has been done, we can reopen the issue.

Keep in mind that the "Resolved"-Status on this ticket just means "Answered", and that we are waiting for further information on whether this issue still exists or not. We will reopen it as soon as the requested information has been delivered.

ChocolateChip Cookies 2015-07-01T05:05:47Z

Comfirmed in 1.8.7.

LuxiKeks 2017-12-21T15:45:22Z

Still an issue in 1.12.2 and 1.13 snapshots.

violine1101 2017-12-27T14:29:37Z

Reopened.
@unknown, which Minecraft 1.13 snapshot?

marcono1234 2017-12-27T17:53:53Z

I changed the report a little bit, I hope it still describes the bug you meant.

LuxiKeks 2017-12-29T12:08:40Z

@violine1101: all the 1.13 snapshots are affected.

LuxiKeks 2018-08-30T07:07:31Z

Affects 1.13.1

LuxiKeks 2019-07-24T13:53:31Z

Affects all 1.14 version as well.

LuxiKeks 2019-08-29T10:08:18Z

Affecting 19w35a.

Jackson 2020-02-07T02:02:54Z

On my survival 1.15.2 world I have the same issue but I would like to add that during my daily midday (exactly) thunderstorm, it also gets dark enough for mobs to start spawning around the player within 30 seconds of the light level dropping. After the storm it is still early afternoon same day.

Michael Clark 2020-05-02T09:24:47Z

This appears to be a duplicate of MC-3865.

violine1101 2020-05-03T18:58:53Z

Doesn't look like the same issue to me.

Tokes 2020-12-17T01:53:07Z

The core problem is sleeping resets the rain counter and usually picks a value longer than 1 day (more than 95% of the time). So if you sleep to skip night every night it almost never reaches the point where rain starts. The exceptions seen usually are because of not skipping a night due to mining, or intentionally not skipping night so you can get monster fights. So it's a bug in the sense of poorly planned game logic, not a mis-programming in the implementation.

The best solution is to make skipping the night not reset the counter unless it's raining, although changing the range of the roll so that it happens before sunset 25 percent of the time would work too.

fescar 2021-02-28T17:06:51Z

Affects 1.16.5

Dylan Peterson 2021-06-25T18:54:41Z

This appears to be the bug for me. Can confirm for 1.17 and 1.17.1 Prerelease 1. I hope they fix this soon, and I'm glad they prioritize this as important, because it really is, especially considering that snowfall and thunder have a use now.