[MC-93164] Using a hotkey on items in inventory slots you can't insert items into (e.g. Crafting table output) only works if slot is empty

Using the 1-9 hotkeys to move an item to the 1-9 slots used to move the item there in any inventory (moving items that were already there to a different slot if needed), only not working if the player's inventory was full. However, as of the 15w44b snapshot, this no longer works; it will now only put the item in the slot if it is free.

Steps to reproduce:
1. Sort your inventory so you have any item in your first slot.
2. Enter an inventory, such as an Anvil, Crafting Table or Furnace.
3. Produce an item in their output slots (e.g. by crafting, smelting or combining).
4. Hover over the item and press the 1 key.

Video: https://imgur.com/GN2itSo

Expected Result:
The number 1 slot is replaced with the item from the inventory & the item originally in the 1 slot will enter the second slot.

Acquired Result:
The item stays in the inventory & the item currently in the first slot stays there.

Ways to Fix:
Revert to the behaviour of <1.8.8 & <15w44b, pretty sure Grum has been fixing a few bugs associated with hotkeys, stacking behaviour and inventories recently - so he must have made a change somewhere that produced this bug.

Other Steps to reproduce:

Place valid recipe contents in crafting grid
in 1.8.9
- Pressing hotbarkey of slot with item same as crafted item will add the item to the hotbar
- Pressing hotbarkey of slot with other item as crafted item will swap empty hotbar slot with occupied and place crafted item to the hotbar
- Pressing hotbarkey of empty slot places item there
in 1.9-pre4
- ~~Pressing hotbarkey of slot with item same as crafted item will add the item to the hotbar~~ (No longer works)
- ~~Pressing hotbarkey of slot with other item as crafted item will swap empty hotbar slot with occupied and place crafted item to the hotbar~~ (No longer works)
- Pressing hotbarkey of empty slot places item there (Still working)

Linked issues

is duplicated by 6

MC-97678 Created tool won't go on valid place in hotbar by pressing numbers. Resolved

MC-98264 Pressing number key while crafting no longer places result in occupied hotbar slot Resolved

MC-105972 Number crafting spam Resolved

MC-150937 Items cannot be crafted with numbers 1-9 when another item is in that slot Resolved

MC-164202 Quickcrafting doesn't work Resolved

1 more links

Attachments

1.14 bug.mp4

15w44a.mp4

15w44b bug.mp4

Comments 30

[Mod] redstonehelper 2015-11-22T17:34:07Z

Works as intended. 1-9 keys exchange items, they do not move items. If two slots can't be exchanged (you can't put items into the crafting table output slot, for example), nothing happens. The fact that something happened before was a bug.

Matthew Curran 2015-11-22T17:46:13Z

Before, it would put the item from the crafting grid in the slot and move the other item into the inventory. If the inventory was full it wouldn't work. I know a lot of people use this function and it doesn't really make sense for it to not work.

[Mod] redstonehelper 2015-11-22T17:47:33Z

Right, reopening. The partial fix for MC-7222 (which is probably the cause of this issue) added some situations where you can 1-9 hotkey without the slots exchanging completely.

Matthew Curran 2015-11-22T17:50:02Z

Ah thanks, hope both bugs get fixed.

Matthew Curran 2015-11-22T17:51:52Z

You can update MC-7222 with this info and close my report if you want. Makes it easier to fix.

20 more comments

[Mod] redstonehelper 2015-11-22T17:54:11Z

I think they're separate issues.

Matthew Curran 2015-11-22T17:55:40Z

Ok thanks. Also yeah I looked into it more and it only happens with slots you can't insert items into, e.g. Crafting table right slot, furnace right slot, anvil right slot.

Jeremiah Robert Turner 2016-02-25T21:11:57Z

Confirmed that this still occurs in 1.9 Pre release 3. If I craft an item using either the craft table, personal craft table in inventory, Anvil, or Furnace and attempt to acquire it using a hotkey it only works when the slot related to the hotkey is empty. For Example:

Setup: Hotkey slot 1 is empty, hotkey slot 2 is not, at least one slot in the player inventory is empty.
1. Craft a stone pickaxe
2. hover over the stone pickaxe in the craft table output and push hotkey 1

Expected result: the stone pickaxe is placed in slot 1.
Actual result: the stone pick is placed in slot 1.

3. Repeat step 1
4. hover over the stone pickaxe in the craft table output and push hotkey 2

Expected result: the stone pickaxe is placed in slot 2 and the item in slot 2 is placed in and empty inventory slot.
Actual result: the stone pickaxe is NOT placed in slot 2 and the item in slot 2 remains in slot 2.

note 1: The expected behavior works as described in 1.8.9.
Note 2: The same test may be performed with any item that holds inventory (e.g. chest, craft table input, player inventory).

bob 2016-11-06T11:11:10Z

Is this still an issue in the latest snapshot 16w44a? If so please update the affected versions.

This is an automated comment on any open or reopened issue with out-of-date affected versions.

Paint 2017-02-03T22:12:37Z

Confirmed for 1.11.2

marcono1234 2017-03-02T13:39:26Z

Kind of an code analysis side note:
In 1.11.2 this inventory action swaps items (method net.minecraft.inventory.Container.slotClick(int, int, ClickType, EntityPlayer), ClickType.SWAP case), but as you cannot put items in the crafting output no items will be swapped, which means this behavior could be intended. However, as the player very likely knows that she / he cannot put an item in the slot but pressed a hotbar number anyways, she / he is very likely expecting something different to happen. Therefor it might make sense to act like in previous versions if the the items can only be taken but no item can be put in the slot.

Or the swap behavior could be changed in general because it appears that swapping the same item but with different counts is most of the time redundant. Therefor maybe always merge the item to the hotbar slot if only a number is pressed and if shift is pressed while a number is pressed move the item from the hotbar to the hovered slot?

muzikbike 2018-12-14T19:36:21Z

Affects 18w50a, can I request ownership of this ticket?