Clicking a settings button when there's a slider under the mouse in the next screen plays the click sound twice

Noticed that this can happen on any slider. You can click in empty space, don't let go of the mouse click button, then move the cursor over a slider, then let go. It will play a click sound but nothing will happen.

Tested on 1.14.2 Release. Windows 10, Java edition.

This is still an issue in 1.15 prerelease 6. Please fix before 1.15.

fix this now you are too late and still in 1.15

and 20w06a

Still in 20w09a

Still in 20w10a

can conferm still present as up to 1.16   20w20b

Exist if you click "Chat settings" (for me)

I'm making a mod of beta 1.7.3 (MCP) and when I was adding the GUI code from 1.16, I noticed the existence of this bug. Well, that's not important. The important part is that I found the way to fix it and I decided to share it (the code):

1- Add a boolean to net.minecraft.client.gui.components.AbstractSliderButton, in my case:

"private boolean wasClicked = false;"

2- Then go to the method "void onClick(double, double)" and write "this.wasClicked = true;" in the last line of the method.

3- Remove all the operations of the method "void onRelease(double, double)" and add this:
     if (this.wasClicked)
     {
            super.playDownSound(Minecraft.getInstance().getSoundManager());
            this.wasClicked = false;
     }

Also confirming, still present in 1.16.1.

I might add that this effect is also created when you push the mouse button down, hearing a click and entering a menu, move the mouse to be on top of a slider, and then releasing. You still get an extra click. A nice place to demonstrate this is from the Minecraft title screen: move the mouse over the Options button, press down on Left Click, continue to hold down the button while moving the mouse up to the FOV slider, then release. Extra click sound.

EDIT: Strangely, moving the mouse to be over a slider does not produce the extra sound when entering the Video Settings menu, but does work in Options, Music & Sounds, Controls, Chat Settings, and Accessibility Settings.

yea that not right

I can confirm that this is also present in 1.16.4 and in snapshot 20w45a.

Can confirm in 1.17.1.

I'm a minecraft modder, and I accidentally found the source of this bug while making a custom GUI.

The problem is, as Joey mentioned above, because minecraft is coded to play the click sound for sliders on mouse release (see: AbstractSliderButton.java, method onRelease). Because the GUI changes on the mouse press, not release, the GUI elements have changed by the time you are releasing the mouse, resulting in the repeat of the sound. This can be resolved by adding some checks around the playDownSound call to make sure you've actually been manipulating the slider.

Alternatively, the buttons could simply activate on mouse release instead of on mouse click. That would be more consistent with most other UIs anyway.

Hi Fabian,

The buttons already play sound on onRelease. The lack of checks around this is the reason this issue exists.

With "activate", I meant the button action, like opening the next menu. The only reason you "release" the sound option button for example is because it disappears because it already switched to the next menu, even though the mouse is still held.

Still in 1.18. pre-1

Affects 1.18.1
(The "Music & Sound" button worked for me)

Still in 22w03a