[MC-3930] colormaps/foliage.png not affecting birch and spruce leaves, watercolor.png not changing water at all

the foliagecolor.png part of texture packs only affects regular oak and jungle trees. it has no effect on either spruce or birch ones, they're always default green even if you recolor your texture pack's foliage to red or blue.

same goes for watercolor, except it doesn't do anything at all. no matter what you recolor it to, water will remain blue.

Resource pack of MC-30445 can be used to reproduce.

Attachments

Comments 31

Mustek 2012-11-29T11:48:32Z

This site is for bug reports only. For feature suggestions/changes please use the MineCraft Forums: Suggestions.

James 2013-09-05T11:45:46Z

i don't think the water is a problem anymore but the spruce and birch leaves "BUG" still occurs.. would be nice to see this "BUG" fixed..
due to the subject (the leaves) this should be considered a bug as all the others of the same type (leaves) including ones made in the same category(leaves) after those two, had the ability applied to it..

its not something that would arise without being shown and if this keeps getting side stepped as a Feature/Suggestion we will likely never see it Fixed..

(we all know how much they love adding suggested features O.o)

please get this seen by Mojang..

branza 2014-01-25T14:07:37Z

This is a bug, it doesn't make sense that birch and spruce leaves can't be changed by resource packs, but the other leaves can. Every texture and color should be changeable with resource packs.

Hartspoon 2014-03-03T21:17:47Z

If birch and spruce leaves not being coloured by foliagecolor.png isn't a bug, how come leaves_birch.png and leaves_spruce.png aren't coloured in the first place?

It doesn't really make sense to use a greyscale image, allowing the game to recolour it dynamically, if the said colour is then hardcoded in the game.

This should be marked as unresolved and confirmed.

kumasasa 2014-03-03T21:48:56Z

In fact the colour is hardcoded, reopened:

BlockOldLeaf.java (as of MCP 9.03 / Minecraft 1.7.2)

/**
     * Gets the foliage color for birch type (metadata 2) trees
     */
    public static int getFoliageColorBirch()
    {
        return 8431445;
    }

21 more comments

Deleted account 2014-05-06T11:19:38Z

Is this still a concern in the current Minecraft version 14w19a / Launcher version 1.3.11 or later? If so, please update the affected versions in order to best aid Mojang ensuring bugs are still valid in the latest releases/pre-releases.

James 2014-05-10T01:09:42Z

yeah this issues still occurs
in the latest snapshot'
http://imgur.com/rMHEn1Y

would be great to see it resolved'

James 2014-05-10T04:30:00Z

latest snapshot as of May/10/2014

Tangent65536 2014-05-24T06:34:36Z

Last seen on 14w20b.
Also have no effects all the foliage, vine and lily pad in the inventory while grass are affected by the given colormap.
lily pad "block" is not affected, but vine "blocks" are.
Hope the problem will be resolved. 🙂

galaxy_2alex 2014-10-24T21:28:23Z

Is this still a concern in the current Minecraft version 1.8.1 Prerelease 3 / Launcher version 1.5.3 or later? If so, please update the affected versions in order to best aid Mojang ensuring bugs are still valid in the latest releases/pre-releases.

James 2014-10-25T03:32:16Z

it is still occurring will add updated picture. (as of 1.8.1-pre3)

James 2014-10-25T03:33:42Z

Spruce and Birch ignore Foliage color Map 1.8.1-pre3

marcono1234 2015-04-08T13:22:16Z

Confirmed for

1.8.3 however FallingSand blocks with Block:leaves apparently use foliagecolor.png

marcono1234 2015-12-24T16:25:56Z

Confirmed for

15w51b

Based on the code it seems to be intended:

colorMultiplier(IBlockAccess worldIn, BlockPos pos, int renderPass) method of the net.minecraft.block.BlockOldLeaf class (MCP 1.8 names)

public int colorMultiplier(IBlockAccess worldIn, BlockPos pos, int renderPass)
{
	IBlockState var4 = worldIn.getBlockState(pos);

	if (var4.getBlock() == this)
	{
		BlockPlanks.EnumType var5 = (BlockPlanks.EnumType)var4.getValue(VARIANT_PROP);

		if (var5 == BlockPlanks.EnumType.SPRUCE)
		{
			return ColorizerFoliage.getFoliageColorPine();
		}

		if (var5 == BlockPlanks.EnumType.BIRCH)
		{
			return ColorizerFoliage.getFoliageColorBirch();
		}
	}

	return super.colorMultiplier(worldIn, pos, renderPass);
}

colorMultiplier(IBlockAccess worldIn, BlockPos pos, int renderPass) method of the net.minecraft.block.BlockLilyPad class

public int colorMultiplier(IBlockAccess worldIn, BlockPos pos, int renderPass)
{
	return 2129968;
}

yarrmateys 2015-12-25T18:47:49Z

it may be intended, but it may as well be something that was missed when the trees were upgraded from all hardcoded values to the new method.

the new ones use the newer method as well as far as i know.

FaRo1 2016-07-01T17:11:06Z

According to http://minecraft.gamepedia.com/Resource_pack#Folder_structure there is no "foliagecolor.png". Was this changed to "assets/minecraft/textures/colormap/foliage.png"?

August Zellmer 2016-07-01T20:52:11Z

Fabian: Yes. That is the new name of the file. And I wouldn't be surprised if watercolor.png has moved as well. But the glitch is still the same - these files exist and are supported by texture packs, but birch trees ignore the foliage file and the watercolor file is ignored entirely.

galaxy_2alex 2016-09-26T22:06:41Z

Is this still a concern in the current Minecraft version? If so, please update the affected versions in order to best aid Mojang ensuring bugs are still valid in the latest releases/pre-releases. If this has been done, we can reopen the issue.

Keep in mind that the "Resolved"-Status on this ticket just means "Answered", and that we are waiting for further information on whether this issue still exists or not. It will be reopened as soon as the requested information has been delivered.

marcono1234 2016-09-27T16:36:03Z

Confirmed for

16w38a

Resource pack of MC-30445 can be used

r543 2017-06-28T11:19:31Z

Not to sound rude, but this is still a issue(in past when MCpatcher, a 3rd party thing, was still supported, you could use it to change the foilage AND water color, which worked nice), does Mojang ever intend to fix this?
Last post I've found was from a year ago, stating that Mojang wants to give texture pack creators more freedom regarding colors, yet still nothing has happened, come on, allow us to customize those hardcoded colors.
Edit: more related to the Swamp & Mesa colors, but since those are all "Resolved" I decided to ask here, hope it isn't too rude.

Meri Diana 2017-06-28T11:54:52Z

@unknown Do you refer to this post here by Mr. Broes on Mojira's Reddit for MC-30445?

Well from what I've heard, they initially planned to have all old "data values" removed already in 1.12 and it seems they're aiming now for 1.13, as for the block ID update - what I mean by that example is: Good stuff needs a good amount of time 🙂 It isn't easy to implement such a huge change into the current code, I've read a few times that the "code crumbled away" under some Devs' fingers when they tried to add something cool 😞

Also, I suppose they're still aiming for feature parity, which means that a change in Java-MC would possibly also have to be somehow implemented in the versions for other platforms, which would involve even more Devs who are maybe busy with (and have to prioritise) other stuff currently.. who knows.

But I recently read something about being able to change the Sky colours and foliage etc. in MAYBE 1.13 via Vanilla means (no MCPatcher/Optifine).. ah, found it, it was Mr. Broes on Reddit 🙂
And here another Reddit-reply of Mr. Bergensten, involving future respack plans 🙂

TLDR: It might often not seem that way, but some Devs actually care about some really neat future additions, but adding them isn't always possible due to various reasons, sometimes needing more time than initially planned.

I can only ask you (and others) for some more patience 🙂)
And sending some Love every now and then to the Devs might also help to encourage them in continue caring 😉

user-f2760 2017-06-28T11:55:14Z

when MCpatcher, a 3rd party thing, was still supported

It never was supported

does Mojang ever intend to fix this

It's marked as postponed, meaning that it will be fixed later.

allow us to customize those hardcoded colors.

reddit:

Mojang really need to make it easier to edit the skybox and biome/foliage/light colors.
@unknown: I have a branch with a prototype for this somewhere, might have time to work on it for 1.13 🙂

Kaari Koehn 2018-11-10T15:36:58Z

Tip from HeroQBE in minecraftforum.net, possible workaround:

"For editing e.g. birch leaf color create or edit the file birch_leaves.json in the folder YourResourcepack\assets\minecraft\models\block\ and edit it like that:

{{{}}
"parent": "block/cube_all",
"textures": {
"all": "blocks/leaves_birch"
}
{{}}}

That will just turn off the block tint and you can change the leaves_birch.png in the YourResourcepack\assets\minecraft\textures\blocks\ folder like you want 🙂 "

I haven't tried this yet myself.

Meri Diana 2018-11-13T08:38:19Z

If needed, the workaround as described by @unknown works, however the correct birch_leaves.json is:

{
    "parent": "block/cube_all",
    "textures": {
       "all": "block/birch_leaves"
     }
}

[media]

which results in a completely colourless, gray leaves texture that doesn't use the foliage.png as tint source.

[media]

In order to have the birch leaves coloured, you have to colour the birch_leaves.png file.

Mike Vandeveer 2019-01-08T19:09:47Z

I'm kind of getting sick of this being an issue and the fact that the other articles are "resolved" all leading to this one that is still open and is "postponed" it feels more like the devs should just tell us they don't intend to do shit about it, throw an "abandoned" into the labels, and add it to this issue.

Meri Diana 2019-01-08T19:36:18Z

@unknown In my opinion, "Postponed" leaves open a hope, than not intending to do anything about it at all.
Didn't you read what was written here in the comments? Mr. Broes mentioned on Reddit that he got a prototype for it, however - from own experience and those of what I've read from Mojira mods - it isn't always easy to implement certain things into Minecraft, due to various reasons, let alone having to make priority decisions.

For the time being, I inserted a json with which you can work with, if you want to colour birch leaves.

I can very well understand frustration, but I have yet to see that venting against someone who isn't on your payroll or you have got some other form of power over, but you want something from them, will turn out in 100% of the cases to the favour of the angry person. So if you want to do yourself and the rest of us, who'd love this to be done someday, a favour, try to keep your criticism as humane as you can, and, if that critique contains nothing that really contributes to a bugpost, then do this preferrably outside of this bugtracker, e.g. on the Mojira Subreddit, thank you.

Adrian Östergård 2019-09-17T07:24:16Z

This is a feature request.

FaRo1 2019-09-17T08:57:03Z

How so? The water colouring is already implemented, it just doesn't work. And that certain leaves are not affected is at least an inconsistency.

Meri Diana 2019-09-17T09:51:34Z

@unknown I absolutely agree with @unknown and also want to state that this is an inconsistency.

If this bugpost would have been resolved as WAI without giving any reason, I would have assumed something which is intel I've gotten several years ago though.

Back then I asked a dev regarding textures such as foliage, (custom) sky, environment etc., and he wrote something along the lines of, that some things related to texturepacks would require a massive rewrite. That he actually already tried to implement something which is currently hardcoded, but it didn't work out with that code base (don't nail me down 100% to those words, it's saved similar like this in my memory, I mainly recall that he wanted to give texturepack makers more possibilities, but it was not possible at that time).

From what I know so far about this bugtracker, is, that in some cases "works as intended" can also mean something like "we can't currently do this, it may be fixed one day, it also might not be on the top of our priority list, and it may very well be that, if it will be possible one day, it may not be in the format this bugpost refers to, so we might as well close it, and as we must not reveal specific future plans for Minecraft to the public, we sadly can't tell you that this will be possible one day.", but this is apparently not the case here by closing the bugpost as a "feature request".

To emphasize again: Closing this bugpost as a feature request seems wrong, as it's also for me an inconsistency.

I am aware that since the acquisition by Microsoft, plans may have changed tremendously, which is not the Devs' fault, but, regardless, I want to link again a Redditpost by Mr. Broes:
https://www.reddit.com/r/Minecraft/comments/66gcg9/comment/dgiy1xb

It would be very kind of you, Mr. Östergård, to ask the developer who would be currently responsible for theoretically implementing it into Vanilla, so you could re-evaluate to possibly leave this bugpost open, or, if you are allowed to, to give us any intel about future plans regarding this.

Thank you!

violine1101 2019-09-17T10:08:43Z

Please do not use the bug tracker as a discussion forum. Please use /r/Mojira instead.

slicedlime 2019-09-17T12:57:22Z

The inconsistency is intended, which is why this is closed. For Vanilla Minecraft, it is definitely intended that certain types of leaf blocks (like spruce) are intended to always look the same and not be colored by biome variations (much like real life spruce).

We do want to provide more configurability for things like that, and data driving how biome coloring affects block types would be a great thing to have for resource packs - but that is not strictly what this bug is about, and adding it would be adding a feature for extensibility, not fixing this bug in specific.

And again, this not being considered a bug doesn't mean it won't happen, it just means that we do not consider this "faulty" as described in this bug report. As violine noted, please move any further discussion about this to the subreddit.