mojira.dev
MC-82841

Arrows are bright despite being in darkness

When an arrow hits the ground at night-time, it will not be affected by the 'night shader'.

The code

Linked issues

MC-83067 Arrows uneffected by light Resolved MC-83119 Arrows in the end in 15w31a Resolved MC-83520 New arrows appear to have no shading Resolved MC-83555 Arrows glow in the dark Resolved MC-83597 Arrows always appear at full brightness Resolved

Attachments

Comments 49

Confirmed for:

  • 15w31a However it seems that this affects also ShulkerBullets if they are far away

Confirmed for 15w31c

Confirmed in for 15w32a

Confirmed for 15w32b

Confirmed for 15w38b.

39 more comments

Confirmed for 1.10-pre1

Confirmed for 1.10-pre2

Confirmed for 1.10.2

Solution: Remove the getBrightnessForRender() override from class EntityArrow and move it into EntitySpectralArrow. EntityArrow will then inherit the default method from Entity, which gives the desired lighting.

Probably a result of spectral arrows being the same entity class as normal arrows during initial testing, and not being converted to separate classes properly.

Class names and method names taken from MCP namings.

Alexander Ahlgreen Madsen

Erik Broes

Confirmed

arrow, light, water

Minecraft 15w31a, Minecraft 15w31b, Minecraft 15w31c, Minecraft 15w32a, Minecraft 15w32b, ..., Minecraft 16w35a, Minecraft 16w36a, Minecraft 16w38a, Minecraft 16w39a, Minecraft 16w39b

Minecraft 16w39c

Retrieved