Caves can interfere with the generation of strongholds

Seed: -730844123035636832
Co-ords: /tp @s -2227 2 -576
Version: 21w13a

As long as the portal isn't destroyed
It actually looks pretty cool

Can confirm in 21w14a.

This report should be closed because noise caves are removed in 21w15a.

Actually a duplicate of MC-70705 because this report is supposed to be about 1.17 cave gen (which doesn't exist anymore)

This report should remain open because the worldgen data pack is still updated.

Uh, I get this in 1.12. This has ALWAYS been the case, it's just more visible with more caves.

EDIT: the hallway with floating doors and the library with a hole where the floor should be specifically are things I've encountered multiple times in 1.12 and earlier. My library-hole had lava at the bottom though.

In my opinion, it should stay this way. This isn't bad as MC-214814 and it would be really weird if strongholds were completely unable to be exposed in caves and oceans (that's why MC-216191 should be reopened).

Can confirm in 1.17.

Can confirm in 1.17.1.

I'm unsure whether this is the same issue or just a similar one, but in 1.17.1 end portal frames can be overwritten by cave generation. See this reddit post. I tested this myself and verified that this end portal is often overwritten by the cave, but strangely, upon repeated attempts, sometimes the portal wasn't overwritten. These inconsistencies are likely MC-55596. I'll put screenshots of both types of world generation below.

-7908223477499843890
/tp 1336 22 -1479

Nope, blocked by link is the correct way to go.
It isn't fixed, it's unable to be tested because they no longer exist.

This appears to be fixed in 21w38a

I'd like to request for this ticket to be reopened as this issue doesn't appear to be fixed in 21w38a. Here are some steps on how to go about reproducing this in 21w38a.

Steps to Reproduce:

• Enter the following seed and coordinates.

Version 21w38a

Seed: 8961625545290334832
Coordinates: /execute in minecraft:overworld run tp @s 13912.11 7.95 -564.07 91.49 -6.48

• → ❌  Notice how strongholds can still spawn shattered.

Can still confirm in 21w38a

confirmed not fixed in 21w38a

still in 21w39a

Can confirm in 21w40a.

Can confirm in 21w42a

Can confirm in 1.18 pre4

Can confirm in 1.18
 

Relates to MC-249845

This is caused because of code that prevents the walls, floors, and ceilings from replacing air blocks. Jeb originally added this because he "wanted the strongholds to be a little messed up." It does not apply to the stronghold's features and the portal room, which can replace air blocks. Also, it does not apply to a ring of stone bricks that gets generated in place of a room that failed to generate.

This seems to occur exclusively with carver-type caves (i.e. cheese caves, ravines and possibly lava lakes). After the stronghold has generated, but before carvers have taken effect, strongholds will develop a buffer area of solid blocks around them, preventing any intersection with noise caves (although I believe they can still intersect the world surface in some cases).

Since related bugs MC-249845 and MC-266446 were marked as won't fix this should/will probably be as well