Witch Hut structure data do not account for height the witch hut is generated at

Confirmed in 1.8.1-pre3. Seed "Witch hut test" (-1777352604), witch hut generates with bounding box [ 8832, 77, 9456, 8840, 83, 9462 ], well outside the recorded structure bounding box of [ 8832, 64, 9456, 8840, 70, 9462 ].

From the NBT in pseudo-XML:

<[552,591]>
<id>Temple</id>
<ChunkX>552</ChunkX>
<BB>[ 8832, 64, 9456, 8840, 70, 9462 ]</BB>
<ChunkZ>591</ChunkZ>
<Children>
<>
<id>TeSH</id>
<GD>0</GD>
<HPos>77</HPos>
<BB>[ 8832, 77, 9456, 8840, 83, 9462 ]</BB>
<Height>7</Height>
<Witch>1</Witch>
<Width>7</Width>
<O>1</O>
<Depth>9</Depth>
</>
</Children>
</[552,591]>

I did a test on a single player world, this isn't really related to this but other mobs can spawn inside the bounding box too, just witches spawn more often
seed:
109846752
cords:
-2032 70 1568
pictures:
http://imgur.com/7wc5Lcy,NV1kOeG,nUcPo8x,DtumHez,CTp9h6o,wS2ahUG

Seed "Witch hut test" still generates mismatched bounding boxes for the hut at 8832,9456 in 1.8.2-pre1.

Still present in 1.8.2-pre3.

Still present in 1.8.3.

Confirmed for 1.8.6

Confirmed for 1.8.7

Seed "Witch hut test" still generates mismatched bounding boxes for the hut at 8832,9456 in 15w32b.

Still present in 15w50a.

Still present on Xbox One TU 31

@unknown this tracker is for pc edition only

1.9 pre 1 affected

Affects 1.9.4. Is any workaround known for this bug?

Actually, I just discovered a workaround. Simply updating the bounding box in NBTExplorer to the correct height solves it. It's merely an issue of the data in Temple.dat being malformed.

Specifically, find the entry in Temple.dat the pertains to the witch hut (labeled in chunk coords) and then copy the value from ~/Children/BB to ~/BB. That aligns the two bounding boxes on the position where the actual witch hut spawned.

Is this still an issue in the latest snapshot 16w44a? If so please update the affected versions.

This is an automated comment on any open or reopened issue with out-of-date affected versions.

Minecraft 1.11. Witches don't even spawn in or below structures generated above the normal height

I can also confirm this is a problem on 1.11.2, world seed -935057631223221916, witch hut nominally at -864,71,1024, NBTExplorer confirmed that the spawning area was at 64 instead of elevated.

Fixing the spawner to match the apparent caused witches to spawn as expected.

can you add the lates versions on as i am finding this bug in vestion 17w17b

This is still occuring in 1.11.2

@unknown, this version was already marked as affected

i added an image showing where the game thinks the hit box is and where the hut is itself the game can only spawn witchs in the overlap of the hitbox and witch hut

also the hit box will always start at y=64 i found in my tests this is and inportant bit of missing info

This bug is created because of the Temple generator getting an offset when generating. Temples like any other structure has an outer main bounding box and all inner structure bounding boxes, for the case of witch huts only one inner bounding box aka hut exists. To spawn a witch inside a which hut the position needs to be inside both bounding boxes meaning they need to perfectly overlap or any non overlapped areas will fail to spawn a witch.

As is known there is a bug that makes the outer Temple bounding box generate always at Y=64 but the hut bounding box can be offset above or below the Temple bounding box. The main problem is that the Temple and the structure bounding boxes are created prior to generating any other blocks. The Temple is first created then its child structure that places the hut into the world. The hut has a fixed and valid location at Y=64. The Temple bounding box is then rapped around the inner hut bounding box. This can be seen at MapGenScatteredFeature.java line 172.

public Start(World worldIn, Random random, int chunkX, int chunkZ, Biome biomeIn)
        {
            super(chunkX, chunkZ);

            if (biomeIn != Biomes.JUNGLE && biomeIn != Biomes.JUNGLE_HILLS)
            {
                if (biomeIn == Biomes.SWAMPLAND)
                {
                	System.out.println("swampland");
                	Thread.dumpStack();
                    ComponentScatteredFeaturePieces.SwampHut componentscatteredfeaturepieces$swamphut = new ComponentScatteredFeaturePieces.SwampHut(random, chunkX * 16, chunkZ * 16);
                    this.components.add(componentscatteredfeaturepieces$swamphut);
                }
                else if (biomeIn != Biomes.DESERT && biomeIn != Biomes.DESERT_HILLS)
                {
                    if (biomeIn == Biomes.ICE_PLAINS || biomeIn == Biomes.COLD_TAIGA)
                    {
                        ComponentScatteredFeaturePieces.Igloo componentscatteredfeaturepieces$igloo = new ComponentScatteredFeaturePieces.Igloo(random, chunkX * 16, chunkZ * 16);
                        this.components.add(componentscatteredfeaturepieces$igloo);
                    }
                }
                else
                {
                    ComponentScatteredFeaturePieces.DesertPyramid componentscatteredfeaturepieces$desertpyramid = new ComponentScatteredFeaturePieces.DesertPyramid(random, chunkX * 16, chunkZ * 16);
                    this.components.add(componentscatteredfeaturepieces$desertpyramid);
                }
            }
            else
            {
                ComponentScatteredFeaturePieces.JunglePyramid componentscatteredfeaturepieces$junglepyramid = new ComponentScatteredFeaturePieces.JunglePyramid(random, chunkX * 16, chunkZ * 16);
                this.components.add(componentscatteredfeaturepieces$junglepyramid);
            }

            this.updateBoundingBox();
        }

"ComponentScatteredFeaturePieces.SwampHut componentscatteredfeaturepieces$swamphut = new ComponentScatteredFeaturePieces.SwampHut(random, chunkX * 16, chunkZ * 16);
this.components.add(componentscatteredfeaturepieces$swamphut);"
These 2 lines generate the Temple and hut and places them into the world. Then the Temple is wrapped around the hut at line "this.updateBoundingBox();".

Later in the code after the world is generated the hut is placed into the world at the topological terrain. The hut bounding box is then edited in Y height to match the average topological area based on the 4 corners offsetting its location based on the terrain its generated at. The Temple bounding box is not edited at this stage creating an offset. This can be seen in ComponentScatteredFeaturePieces.java in the method addComponentParts under the subclass SwampHut.

public boolean addComponentParts(World worldIn, Random randomIn, StructureBoundingBox structureBoundingBoxIn)
        {
            if (!this.offsetToAverageGroundLevel(worldIn, structureBoundingBoxIn, 0))
            {
                return false;
            }
            else
            {
                this.fillWithBlocks(worldIn, structureBoundingBoxIn, 1, 1, 1, 5, 1, 7, Blocks.PLANKS.getStateFromMeta(BlockPlanks.EnumType.SPRUCE.getMetadata()), Blocks.PLANKS.getStateFromMeta(BlockPlanks.EnumType.SPRUCE.getMetadata()), false);
---more code that was removed---

"offsetToAverageGroundLevel" Edits the hut bounding box when placing it into the world. While the caller to generate and place the hut into the world is called from StructureStart.java line 70 in a method called "writeStructureComponentsToNBT" where the Temple is calling the different "components" to generate. After they are generated in the case of Temple structures unlike other structures the inner bounding boxes are altered in some instances.

TL.DR.
To fix this bug can be done by adding "updateBoundingBox();" method call inside the "writeStructureComponentsToNBT" funtion inside the class StructureStart.java at line 85 like the code example. This is to update the outer bounding box after the inner structure bounding boxes are edited before being saved to disk.

public NBTTagCompound writeStructureComponentsToNBT(int chunkX, int chunkZ)
    {
        NBTTagCompound nbttagcompound = new NBTTagCompound();
        nbttagcompound.setString("id", MapGenStructureIO.getStructureStartName(this));
        nbttagcompound.setInteger("ChunkX", chunkX);
        nbttagcompound.setInteger("ChunkZ", chunkZ);
        nbttagcompound.setTag("BB", this.boundingBox.toNBTTagIntArray());
        NBTTagList nbttaglist = new NBTTagList();

        for (StructureComponent structurecomponent : this.components)
        {
            nbttaglist.appendTag(structurecomponent.createStructureBaseNBT());
            
        }

        updateBoundingBox(); // add this line
        nbttagcompound.setTag("Children", nbttaglist);
        this.writeToNBT(nbttagcompound);
        return nbttagcompound;
    }

A small optimization can also be done by removing most other updateBoundingBox(); calls in unneeded places as its done here in the critical location after the editing of inner bounding boxes are done.