Wearing boots enchanted with depth strider decreases the strength of the riptide enchantment

Still in 1.14.4

Still in 20w22a.

In 1.16.1 and 20w28a. There is a fabric mod fix. https://www.curseforge.com/minecraft/mc-mods/riptide-fix

In 1.16.5. Would love if there is a *proper* fabric mod fix.

Can confirm in 21w05b.

Can confirm in 21w11a.

Can confirm in 1.17.

Really hope they fix this soon! Still an issue in the latest version.

Can confirm in 1.17.1. I've attached a video demonstrating this behavior.

Can confirm this in 21w41a. The expected behavior would be that wearing depth strider boots wouldn't make the riptide effect weaker.

Can confirm in 1.18.1.

Code analysis based on 1.18.1 with yarn mappings.

The reason this happens is because Depth Strider not only increases speed, it also increases drag significantly. Specifically, the player's speed is multiplied by a number every tick. Underwater, this number is typically 0.8 (not sprinting) or 0.9 (sprinting), but it can be as low as 0.546 with Depth Strider III. Presumably this is to prevent "slippery" controls (a la Dolphin's Grace), but this has the side effect of making riptide slow down very quickly.

The easiest way to fix this would be to not increase the drag when riptide is being used. Add this if-statement:

net.minecraft.entity.LivingEntity#travel(Vec3d)

// f is the multiplier, h is the depth strider level
 if (h > 0.0f) {
-    f += (0.54600006f - f) * h / 3.0f;
+    if (this.riptideTicks != 0) {
+        f += (0.54600006f - f) * h / 3.0f;
+    }
     g += (this.getMovementSpeed() - g) * h / 3.0f;
 }

how do i add the line of code to fix it?

That's Mojang's task, not yours. 🙂

yes, but they said to add this to my game so

Can confirm in 1.18.2.

Can confirm in 1.19.

can confirm in 1.18.1

Can confirm in 1.19.2.

Can confirm in 1.20.13

This project/report is for Java Edition only, not bedrock.

Can confirm in 1.20.2

Confirmed in 23w45a

Confirmed in 23w46a

Confirmed in 1.20.3

Confirmed in 24w06a

Confirmed in 24w14a

Can confirm in 1.20.6

Can confirm in 1.21

this also exists on bedrock

Updated commands:

/give @p trident[minecraft:enchantments={"minecraft:riptide":3}]
/give @p diamond_boots[minecraft:enchantments={"minecraft:depth_strider":2}]