The Bug:
Wearing boots enchanted with depth strider decreases the strength of the riptide enchantment.
Steps to Reproduce:
Give yourself some boots enchanted with depth strider and a trident enchanted with riptide by using the commands provided below.
/give @s minecraft:diamond_boots[minecraft:enchantments={"minecraft:depth_strider":3}]/give @s minecraft:trident[minecraft:enchantments={"minecraft:riptide":3}]Equip the boots, enter some water, launch yourself with the riptide enchantment, and take note of how far you traveled.
Now unequip the boots, launch yourself with the riptide enchantment again, and take note of how far you traveled this time.
Observed Behavior:
Wearing boots enchanted with depth strider decreases the strength of the riptide enchantment.
Expected Behavior:
Wearing boots enchanted with depth strider would not decrease the strength of the riptide enchantment.
Code Analysis:
Code analysis by @unknown can be found in this comment.
Linked issues
is duplicated by 20
relates to 2
Attachments
Comments 43
Never used tridents without wearing depth strider 3 boots, so i assumed this was just a weird thing where tridents' movement sucked, but yeah the difference actually makes tridents almost worthless for actual underwater travel (their clearly intended use) (can confirm in 1.21.5)
I looked into this in 1.21.11 (unobfuscated) and found a likely cause in LivingEntity.travelInWater.
It seems that the normal water friction (slowDown, usually 0.9F) is still applied while isAutoSpinningAttack() is active. Because of that, Riptide momentum gets dampened almost immediately, especially when combined with Depth Strider or high WATER_MOVEMENT_EFFICIENCY, which makes the player feel like they stall in water.
A possible fix would be to disable water friction during the Riptide attack, e.g.:
float slowDown = this.isSprinting() ? 0.9F : this.getWaterSlowDown();
if (this.isAutoSpinningAttack()) {
slowDown = 1.0F;
}This would preserve the intended Riptide momentum in water.
Can confirm. I also noticed that using riptide and Dolphin's grace will make you move extremely fast (probably intended).