Shooting potion tipped arrow in creative mode reduces arrow count

Confirmed for 16w06a

Confirmed in 1.9-pre1 as well

Confirmed in 1.9-pre2.

And for 1.9-pre3.

SEE!

There's no need to add additional details, it's already been confirmed.

Sorry

Confirmed for 1.9-pre4

Confirmed for official 1.9 release

Please link to this comment in the description

The following is based on decompiled version of Minecraft 1.9 using MCP 9.24 beta. All method and class names are the names used in the decompiled version.

The reason why this is happening is because the method net.minecraft.item.ItemBow.onPlayerStoppedUsing(ItemStack, World, EntityLivingBase, int) uses two flags (simplified):

flag = creativeMode OR infinityEnchantment
flag1 = flag AND normalArrow

flag1 is used to determine whether the shot arrow can be picked up by Creative players only and whether or not to reduce the arrow count. Instead only one flag is needed.

/**
 * Called when the player stops using an Item (stops holding the right mouse button).
 */
public void onPlayerStoppedUsing(ItemStack stack, World worldIn, EntityLivingBase playerIn, int timeLeft)
{
    if (playerIn instanceof EntityPlayer)
    {
        EntityPlayer entityplayer = (EntityPlayer)playerIn;
        // Replaced this
        //boolean flag = entityplayer.capabilities.isCreativeMode || EnchantmentHelper.getEnchantmentLevel(Enchantments.infinity, stack) > 0;
        //ItemStack itemstack = this.func_185060_a(entityplayer);
        ItemStack itemstack = this.func_185060_a(entityplayer);
        boolean flag = entityplayer.capabilities.isCreativeMode || (itemstack.getItem() == Items.arrow && EnchantmentHelper.getEnchantmentLevel(Enchantments.infinity, stack) > 0);

        if (itemstack != null || flag)
        {
            if (itemstack == null)
            {
                itemstack = new ItemStack(Items.arrow);
            }

            int i = this.getMaxItemUseDuration(stack) - timeLeft;
            float f = func_185059_b(i);

            if ((double)f >= 0.1D)
            {
                // Not needed anymore
                //boolean flag1 = flag && itemstack.getItem() == Items.arrow;

                if (!worldIn.isRemote)
                {
                    ItemArrow itemarrow = (ItemArrow)((ItemArrow)(itemstack.getItem() instanceof ItemArrow ? itemstack.getItem() : Items.arrow));
                    EntityArrow entityarrow = itemarrow.func_185052_a(worldIn, itemstack, entityplayer);
                    entityarrow.func_184547_a(entityplayer, entityplayer.rotationPitch, entityplayer.rotationYaw, 0.0F, f * 3.0F, 1.0F);

                    if (f == 1.0F)
                    {
                        entityarrow.setIsCritical(true);
                    }

                    int j = EnchantmentHelper.getEnchantmentLevel(Enchantments.power, stack);

                    if (j > 0)
                    {
                        entityarrow.setDamage(entityarrow.getDamage() + (double)j * 0.5D + 0.5D);
                    }

                    int k = EnchantmentHelper.getEnchantmentLevel(Enchantments.punch, stack);

                    if (k > 0)
                    {
                        entityarrow.setKnockbackStrength(k);
                    }

                    if (EnchantmentHelper.getEnchantmentLevel(Enchantments.flame, stack) > 0)
                    {
                        entityarrow.setFire(100);
                    }

                    stack.damageItem(1, entityplayer);

                    // Replaced this
                    //if (flag1)
                    if (flag)
                    {
                        entityarrow.canBePickedUp = EntityArrow.PickupStatus.CREATIVE_ONLY;
                    }

                    worldIn.spawnEntityInWorld(entityarrow);
                }

                worldIn.func_184148_a((EntityPlayer)null, entityplayer.posX, entityplayer.posY, entityplayer.posZ, SoundEvents.entity_arrow_shoot, SoundCategory.NEUTRAL, 1.0F, 1.0F / (itemRand.nextFloat() * 0.4F + 1.2F) + f * 0.5F);

                // Replaced this
                //if (!flag1)
                if (!flag)
                {
                    --itemstack.stackSize;

                    if (itemstack.stackSize == 0)
                    {
                        entityplayer.inventory.func_184437_d(itemstack);
                    }
                }

                entityplayer.triggerAchievement(StatList.func_188057_b(this));
            }
        }
    }
}

Confirmed for 1.9.3-pre3